Adds the ability to generate a project using ES2015 template #176

bluzi · 2017-10-21T11:36:20Z

As you requested in my previous PR, I adapted my changes to the 4.16 branch and added tests.
I found it easier to just clone the 4.16 branch and make the changes again, since there were too many conflicts.

Anyway, this PR has everything there was in the previous PR, and also tests for --es2015 and --es5.

Let me know if there's anything else you need before you merge it :)

bluzi · 2017-10-21T17:05:17Z

Seems like there are some linter warnings, I'll fix them soon. Feel free to look at the code in the meanwhile.

bluzi · 2017-10-28T16:44:49Z

Weird, I can't reproduce the linting errors Travis shows on my local copy.
I ran npm run lint and it produced no errors. Also, all tests in npm run test-ci pass. (that's also the situation in Travis)

@dougwilson, I'm pretty sure my code is OK and ready to be merged.

dougwilson · 2017-10-28T16:49:42Z

If you look at the diff on here you can see the linting issues, including that it seems like a lot of unrelated changes to your actual change are in this PR. The Github merge button is disabled until the CI is passing. The purpose of the CI runs is so that it can run in a known-good environment just in case there is something wrong locally. I can produce the same linting errors on my machine as I am seeing on Travis, so there may be somethig going on on your local. You can use the output from Travis CI to manually make the fixes, at least.

Alternatively I can help out by making them for you, but I will need to do this when I am at a computer and may be a bit, apologies.

dougwilson

Just a couple comments and can you add a test for the autoderection functionality?

dougwilson · 2017-10-28T16:50:36Z

bin/express-cli.js

@@ -9,6 +9,7 @@ var program = require('commander')
 var readline = require('readline')
 var sortedObject = require('sorted-object')
 var util = require('util')
+var detect = require('feature-detect-es6')


This should be alphabetized

dougwilson · 2017-10-28T16:51:18Z

package.json

@@ -28,6 +28,7 @@
    "commander": "2.11.0",
    "ejs": "2.5.7",
    "minimatch": "3.0.4",
+    "feature-detect-es6": "^1.3.1",


Need to change to specific version instead of verion range.

Also alphabetize

dougwilson · 2017-10-28T16:53:21Z

bin/express-cli.js

@@ -68,7 +76,7 @@ if (!exit.exited) {
 * Install an around function; AOP.
 */

-function around (obj, method, fn) {


There are a lot of changes like this that don't seem related to yiur changes. In fact deleting the space is a linting error

bluzi · 2017-10-28T16:57:00Z

Hey @dougwilson, you're right. Looking at the diffs, I see them too.
Must be vscode's auto-formatting

dougwilson · 2017-10-28T17:00:16Z

P.S. I will help make the above changes if you don't get to it first; I wanted to list them in case you have time, otherwise no worries.

bluzi · 2017-10-28T17:18:54Z

@dougwilson I've fixed all of the linting issues, as well as the other comments you had.
As to the auto detection test - Could you please elaborate what you had in mind? Travis runs the tests on multiple node versions, but I can't think of a way I could know which version of node is currently executing the test.

imcodingideas · 2018-01-16T01:28:33Z

@dougwilson is there anything I can do to help move this PR along?

dougwilson · 2018-01-16T01:32:15Z

Just needs the test suite to pass in CI and tests added for the auto detection feature that was added in the PR 👌 Sorry I haven't been able to do this myself, but if someone is willing to that would help get this moving again without waiting for me 😄

bluzi · 2018-01-16T09:04:26Z

Sorry, but I also don't have time to finish the PR at the moment. If anyone wants to jump in and fix the tests (it's the only thing that's left, don't think it'll take more than few hours tops), read the PR and create your on PR in my fork.

dougwilson · 2018-01-16T11:58:08Z

I do plan to help finish the PR for you, just haven't gotten to it. It seems @imcodingideas is willing to help out 👌

bluzi · 2018-01-16T13:21:03Z

test/cmd.js

@@ -1014,6 +1014,128 @@ describe('express(1)', function () {
        })
      })
    })
+
+    describe('es2015', function () {


@imcodingideas / @dougwilson, if you want to help:
The only issue I know about, is that the --es2015 flag test also runs in older Node environments in the CI.
Because older versions doesn't support es2015, the test fails when it tries to run the generated application, that obviously contains es2015 code. (as it was generated with --es2015 flag)

We should either:

Test es2015 support even when the --es2015 flag is presented, and show error message when a user tries to generate es2015 application on an environment where es2015 is not supported.

"Disable" this test if it runs on older Node versions, where es2015 is not supported.

If you'd like to help, feel free to discuss it and clear out what exactly should be done to solve this (@dougwilson), or just go ahead and implement it yourselves.
That said, I might jump in and just do it myself if I'll find the time :)

Thanks!

OK. I like the test es2015 support when you use the flag. I'm just seeing these messages. I've had a long month.

imcodingideas · 2018-02-12T06:38:15Z

Just an update on this PR. I added a flag to check if the current node version supports these features with: detect.all('const', 'let', 'arrowFunction') in the beforeEach though it seems that this.skip() fails to skip tests with nested describe calls as you can see it's getting fixed here: mochajs/mocha#3225

bluzi · 2018-02-12T09:16:01Z

Just make an if condition then IMHO

imcodingideas · 2018-02-12T15:49:21Z

@bluzi Im going to wrap this up today at work. This could have been an easy fix but the issue I was running into last night was because the nested describe calls. What I will do is just like you said, wrap everything inside the first before in the if. I can get truthly statement to work when I add the same skip feature inside the nested before and after. I'll come up with something today.

describe('es2015', function() {
  before(function() {
    if (detectFeature) {
      this.skip()
    }
  })

  it('blah blah', function(done) {
    // somethings here.
  })

  describe('npm start', function() {
    before(function() {
      // something here.
    })

    after(function() {
      // after
    })

    it('blah blah', function(done) {
      // somethings here.
    })
  })
})

ZeroCho · 2018-02-24T08:33:12Z

@imcodingideas Do you mean that mochajs/mocha#3225 needs to be fixed first to implement your code?
As this.skip() makes test fail?

BTW, I'm really looking forward to this PR being merged.

bencmbrook · 2018-05-24T18:27:26Z

Was this PR abandoned? Would love to see updated syntax.

iDhruv22 · 2018-09-17T07:03:07Z

Any update on PR?
Need to add "import" "export" instead of require().

arnavb · 2019-01-19T23:01:54Z

It's 2019 already. I'm also looking for this functionality; when will this PR be updated?

bluzi added 2 commits October 21, 2017 14:07

Adds the ability to generate a project using ES2015 template

759b678

add tests for --es2015 and --es5 options

071470d

bluzi mentioned this pull request Oct 21, 2017

Adds the ability to generate a project using ES2015 template #174

Closed

Adds --es5 and --es2015 flags to documentation

7f4713e

dougwilson self-assigned this Oct 28, 2017

dougwilson added enhancement pr labels Oct 28, 2017

dougwilson suggested changes Oct 28, 2017

View reviewed changes

fixing linting issues

c0edf63

gasp mentioned this pull request Nov 20, 2017

eslint: change isNaN to Number.isNaN bluzi/generator#2

Open

bluzi commented Jan 16, 2018

View reviewed changes

bferris1 mentioned this pull request Jan 23, 2018

ES2015 standards #167

Open

dougwilson changed the base branch from 4.16 to master March 15, 2018 22:29

dougwilson added the needs rebase label Mar 15, 2018

dougwilson force-pushed the master branch from 2b161cc to e4ef06a Compare March 1, 2022 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds the ability to generate a project using ES2015 template #176

Adds the ability to generate a project using ES2015 template #176

bluzi commented Oct 21, 2017

bluzi commented Oct 21, 2017

bluzi commented Oct 28, 2017

dougwilson commented Oct 28, 2017

dougwilson left a comment

dougwilson Oct 28, 2017

dougwilson Oct 28, 2017

dougwilson Oct 28, 2017

dougwilson Oct 28, 2017

bluzi commented Oct 28, 2017

dougwilson commented Oct 28, 2017

bluzi commented Oct 28, 2017

imcodingideas commented Jan 16, 2018

dougwilson commented Jan 16, 2018

bluzi commented Jan 16, 2018

dougwilson commented Jan 16, 2018

bluzi Jan 16, 2018 •

edited

imcodingideas Feb 12, 2018

imcodingideas commented Feb 12, 2018 •

edited

bluzi commented Feb 12, 2018

imcodingideas commented Feb 12, 2018 •

edited

ZeroCho commented Feb 24, 2018 •

edited

bencmbrook commented May 24, 2018

iDhruv22 commented Sep 17, 2018

arnavb commented Jan 19, 2019

Adds the ability to generate a project using ES2015 template #176

Are you sure you want to change the base?

Adds the ability to generate a project using ES2015 template #176

Conversation

bluzi commented Oct 21, 2017

bluzi commented Oct 21, 2017

bluzi commented Oct 28, 2017

dougwilson commented Oct 28, 2017

dougwilson left a comment

Choose a reason for hiding this comment

dougwilson Oct 28, 2017

Choose a reason for hiding this comment

dougwilson Oct 28, 2017

Choose a reason for hiding this comment

dougwilson Oct 28, 2017

Choose a reason for hiding this comment

dougwilson Oct 28, 2017

Choose a reason for hiding this comment

bluzi commented Oct 28, 2017

dougwilson commented Oct 28, 2017

bluzi commented Oct 28, 2017

imcodingideas commented Jan 16, 2018

dougwilson commented Jan 16, 2018

bluzi commented Jan 16, 2018

dougwilson commented Jan 16, 2018

bluzi Jan 16, 2018 • edited

Choose a reason for hiding this comment

imcodingideas Feb 12, 2018

Choose a reason for hiding this comment

imcodingideas commented Feb 12, 2018 • edited

bluzi commented Feb 12, 2018

imcodingideas commented Feb 12, 2018 • edited

ZeroCho commented Feb 24, 2018 • edited

bencmbrook commented May 24, 2018

iDhruv22 commented Sep 17, 2018

arnavb commented Jan 19, 2019

bluzi Jan 16, 2018 •

edited

imcodingideas commented Feb 12, 2018 •

edited

imcodingideas commented Feb 12, 2018 •

edited

ZeroCho commented Feb 24, 2018 •

edited