Adds the ability to generate a project using ES2015 template #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like AppVeyor fails because of the changes I've made in README.md. That's weird. :/ |
|
This is awesome, thank you! I would really love to get it included in the 4.16 release I was working on before you made your PR, but I haven't released yet. I changed the PR to base on the 4.16 branch, but it looks like there are conflicts it would be great if you could help resolve. Also, can you add tests for the new command line switches? |
|
Sure |
|
I'm closing this PR, since I created new one with the changes you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I added ES2015 support to the generator exactly as discussed in this issue
The generator detects whether it is running on a Node version that supports ES2015, and if it does, it will generate a project using the ES2015 templates. Otherwise, it will generate a project using the good old ES5 templates.
I also added two additional flags:
--es5and--es2015- using one of them will force the generator to use one of these templates, regardless of the Node version.The ES2015 support detection is provided using feature-detect-es6. I tested it a lot and it works flawlessly.
I tested it using the following Node versions, and it works as expected:
Please let me know if you want any changes, or if you have any feature suggestions or anything like that.