Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][ios] Upgrade stripe-react-native to 0.19.0 #19432

Merged
merged 11 commits into from Oct 10, 2022
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Oct 6, 2022

Why

close ENG-6537

How

  • et uvm -m @stripe/stripe-react-native -c 'v0.19.0'
  • backport native stripe version to old sdks' podspec and build.gradle
  • [android] transform manually
    • remove GooglePayButtonManager.kt, GooglePayButtonView.kt
    • remove GooglePayButtonManager() in StripeSdkPackage.kt
    • revert import host.exp.expoview.R change in CardFormView.kt
  • backport versioned code for stripe-android 20.12 breaking changes

[Notable change] bump compileSdkVersion to 33 on android expo go

this is a hard requirement for stripe 0.19.0

Test Plan

  1. clone and setup stripe example app
  2. in example/
  • yarn add file:/path/to/expo/packages/expo
  • yarn add for react-native@0.70.2, react@18.1.0 and other unsynced packages
  • expo start
  1. test android/ios unversioned expo go with the local stripe example app.
  2. there're many different test cases. i just did smoke test from the accepting payments by credit cards.

stripe test api keys: https://stripe.com/docs/keys
stripe test credit card: https://stripe.com/docs/testing

Checklist

@linear
Copy link

linear bot commented Oct 6, 2022

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 6, 2022
@Kudo Kudo marked this pull request as ready for review October 7, 2022 02:43
@Kudo Kudo requested review from lukmccall and removed request for brentvatne and ide October 7, 2022 02:43
@Kudo Kudo merged commit afdb83b into main Oct 10, 2022
@Kudo Kudo deleted the @kudo/sdk47/vendor-stripe branch October 10, 2022 14:59
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 7d6f87e

@aleqsio aleqsio mentioned this pull request Jan 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants