Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stripe] Upgrade stripe to 0.23.1 #20964

Merged
merged 7 commits into from Feb 2, 2023

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Jan 26, 2023

Why

https://linear.app/expo/issue/ENG-7314/update-stripestripe-react-native

How

https://www.notion.so/expo/Updating-stripe-react-native-for-a-new-SDK-release-646ee16729c844e98b8c700d0c04dd1b

Test Plan

Running stripe example app in Expo Go unversioned together with the stripe server following this AWESOME guide from @Kudo #19432
image
image

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 26, 2023
@aleqsio
Copy link
Contributor Author

aleqsio commented Jan 27, 2023

[ISSUE]
This required manually modifying headers in Pods, working on this with @tsapeta

@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Jan 27, 2023
@aleqsio aleqsio force-pushed the @aleqsio/upgrade-react-native-stripe-0.23.1 branch from 3a19785 to 485f150 Compare January 30, 2023 12:51
@aleqsio aleqsio force-pushed the @aleqsio/upgrade-react-native-stripe-0.23.1 branch from 7feb219 to 71f0178 Compare February 1, 2023 14:38
@Kudo
Copy link
Contributor

Kudo commented Feb 1, 2023

thanks for helping this tough module ❤️ 👏

@aleqsio aleqsio force-pushed the @aleqsio/upgrade-react-native-stripe-0.23.1 branch from 71f0178 to 755f744 Compare February 1, 2023 22:36
@aleqsio aleqsio marked this pull request as ready for review February 1, 2023 22:39
@expo-bot
Copy link
Collaborator

expo-bot commented Feb 1, 2023

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against b12df72

@aleqsio aleqsio merged commit 86dbd8e into main Feb 2, 2023
@aleqsio aleqsio deleted the @aleqsio/upgrade-react-native-stripe-0.23.1 branch February 2, 2023 00:13
jakobo added a commit to jakobo/expo that referenced this pull request Feb 2, 2023
…flipper

* upstream/main: (47 commits)
  [docs] Update Hermes guide to state that Hermes is the new default engine (expo#21047)
  chore: don't mark issues with the "Issue accepted" label as stale (expo#21058)
  Switch default JS engine to Hermes (expo#21001)
  [mail-composer][android] fix composeAsync not resolving after send/ discard (expo#20869)
  Update CHANGELOG.md (expo#21061)
  [core][iOS] Fix expo modules aren't added to global (expo#21037)
  [test-suite] Fix import in the Image example (expo#21043)
  [test-suite] fix video hanging (expo#21057)
  [av][ncl][go] fix audio and video qa issues (expo#21055)
  [tools] Selecting pull requests to label in the publish command (expo#20991)
  [document-picker] fill missing descriptions in `DocumentResult` type (expo#21040)
  [tools] Bump http-cache-semantics from 4.1.0 to 4.1.1 (expo#21049)
  Bump http-cache-semantics from 4.1.0 to 4.1.1 in /docs (expo#21050)
  [apps][yarn-workspace] replace deprecated activateKeepAwake
  update changelogs for react-native 0.71 upgrade (expo#20858)
  Upgrade react native to 0.71.2 (expo#21045)
  [go] update @shopify/react-native-skia to 0.1.172 (expo#21014)
  [stripe] Upgrade stripe to 0.23.1 (expo#20964)
  [expo-firebase-*] Remove libraries (expo#20979)
  [docs] Update expo-secure-store to add info about Export compliance (expo#21021)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants