Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @rnc/datetimepicker@6.2.0 ➡️ @rnc/datetimepicker@6.5.0 #19419

Merged
merged 3 commits into from Oct 6, 2022

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Oct 5, 2022

Why

Fixes ENG-6545

How

  • et update-vendored-module --module @react-native-community/datetimepicker --target expo-go --commit bb5ed6f2039c7386ec8f7c0c4de22a73a80860ad

    Upgrade log
    📥 Cloning @react-native-community/datetimepicker#bb5ed6f2039c7386ec8f7c0c4de22a73a80860ad from https://github.com/react-native-community/react-native-datetimepicker.git
    ‼️  Using legacy vendoring for platform ios
    NOTE: In Expo, native Android styles are prefixed with ReactAndroid. Please ensure that resourceNames used for grabbing style of dialogs are being resolved properly.
    
    Cleaning up iOS files at Exponent/Versioned/Core/Api/Components/DateTimePicker ...
    
    Copying iOS files ...
    > ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePicker.h
    > ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePicker.m
    > ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerManager.h
    > ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerManager.m
    > ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerShadowView.h
    > ios/Exponent/Versioned/Core/Api/Components/DateTimePicker/RNDateTimePickerShadowView.m
    
    Updating pbxproj configuration ...
    Adding RNDateTimePickerShadowView.h to pbxproj configuration ...
    Adding RNDateTimePickerShadowView.m to pbxproj configuration ...
    Saving updated pbxproj structure to the file Exponent.xcodeproj/project.pbxproj ...
    
    Successfully updated iOS files, but please make sure Xcode project files are setup correctly in Exponent/Versioned/Core/Api/Components/DateTimePicker
    ‼️  Using legacy vendoring for platform android
    NOTE: In Expo, native Android styles are prefixed with ReactAndroid. Please ensure that resourceNames used for grabbing style of dialogs are being resolved properly.
    
    Cleaning up Android files at expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker ...
    
    Copying Android files ...
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/Common.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/MinuteIntervalSnappableTimePickerDialog.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/ReflectionHelper.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNConstants.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDate.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDialogFragment.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDialogModule.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDatePickerDisplay.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDateTimePickerPackage.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDismissableDatePickerDialog.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNDismissableTimePickerDialog.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDialogFragment.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDialogModule.java
    > android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/components/datetimepicker/RNTimePickerDisplay.java
    ✍️  Updating bundled native modules
    ✍️  Updating workspace dependencies
    💪 Successfully updated @react-native-community/datetimepicker
    

Test Plan

  • Tested in NCL on iOS 16 / iPhone 14 Pro, using unversioned

Checklist

@linear
Copy link

linear bot commented Oct 5, 2022

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 5, 2022
@byCedric byCedric marked this pull request as ready for review October 5, 2022 16:15
@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 5, 2022
@byCedric byCedric force-pushed the @bycedric/sdk-47/upgrade-datetimepicker-to-6.5.0 branch from 2a5b69f to df1398a Compare October 6, 2022 15:31
@expo-bot
Copy link
Collaborator

expo-bot commented Oct 6, 2022

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against df1398a

@byCedric byCedric merged commit 220e170 into main Oct 6, 2022
@byCedric byCedric deleted the @bycedric/sdk-47/upgrade-datetimepicker-to-6.5.0 branch October 6, 2022 15:44
@byCedric byCedric restored the @bycedric/sdk-47/upgrade-datetimepicker-to-6.5.0 branch October 7, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants