Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-native-maps to 1.3.2 #19414

Merged
merged 4 commits into from Oct 7, 2022
Merged

Update react-native-maps to 1.3.2 #19414

merged 4 commits into from Oct 7, 2022

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Oct 5, 2022 •
edited

Why

Update for sdk 47
Closes ENG-6534.

How

There were a lot of native changes and a major version bump.
The following manual change needed to be made to ios/Podfile:

- pod 'GoogleMaps', '~> 3.6'
+ pod 'GoogleMaps', '~> 7.1'
- pod 'Google-Maps-iOS-Utils', '~> 2.1.0'
+ pod 'Google-Maps-iOS-Utils', '~> 4.1.0'

In addition, Expo home uses react-native-maps so fixing a breaking change in typescript types was also required.

Test Plan

Tested manually in Expo Go Android and iOS as well in Bare Expo.

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 5, 2022
@aleqsio aleqsio marked this pull request as ready for review October 5, 2022 14:06
@aleqsio aleqsio marked this pull request as draft October 5, 2022 14:07
@aleqsio aleqsio marked this pull request as ready for review October 5, 2022 14:07
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: needs changes ExpoBot found things that don't meet our guidelines labels Oct 5, 2022
@linear
Copy link

linear bot commented Oct 5, 2022

ENG-6534 react-native-maps

@tsapeta tsapeta changed the title Update react-native-maps Update react-native-maps to 1.3.2 Oct 5, 2022
@aleqsio aleqsio force-pushed the @aleqsio/update-react-native-maps branch from d959698 to 8bb5196 Compare October 7, 2022 08:37
@aleqsio aleqsio force-pushed the @aleqsio/update-react-native-maps branch from 8bb5196 to eea4a3c Compare October 7, 2022 09:08
tsapeta
tsapeta reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fabric-tester submodule update needs to be reverted 🤔

CHANGELOG.md Outdated Show resolved Hide resolved
tsapeta
tsapeta approved these changes Oct 7, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@aleqsio @tsapeta
Add changelog attribution
c0c3504 
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@swmansion.com>
@aleqsio
Copy link
Contributor Author

aleqsio commented Oct 7, 2022 •
edited

Merging as it seems the issue with ios build is the same as caused by:
#19419

@aleqsio aleqsio merged commit f5d1ab4 into main Oct 7, 2022
@aleqsio aleqsio deleted the @aleqsio/update-react-native-maps branch October 7, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@ide ide Awaiting requested review from ide ide is a code owner

@brentvatne brentvatne Awaiting requested review from brentvatne brentvatne is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleqsio @tsapeta @expo-bot