New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Update stripe-react-native to 0.18.1 to fix compilation errors in Xcode 14 #19055
Conversation
228c096
to
4376ff6
Compare
f394898
to
db72ff0
Compare
db72ff0
to
4130903
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Changelog entry in wrong CHANGELOG file
Generated by ExpoBot 🤖 against 4130903 |
Do we have an ETA of when this will be released, and is there anything we can do to help? We, like many, are deadlocked right now with builds failing because of Stripe. |
@Borduhh You can already just upgrade If you're using EAS Build, I also recommend using the default image (not latest). The default images for SDK45 and SDK46 use Xcode 13, so it would still compile fine. |
THANK YOU! I think at one point we needed to use the latest tag, but never looked at the |
Why
It's not possible to build Expo Go with Xcode 14, because of this issue in Stripe iOS: stripe/stripe-ios#1973
Newer version of
@stripe/stripe-react-native
already contains this fix.How
et uvm -m @stripe/stripe-react-native -c v0.18.1 -p ios
rm -rf ios/vendored/unversioned/@stripe/stripe-react-native/ios/Tests
to exclude test specs (I'll automate that separately)Test Plan
Expo Go builds in Xcode 14 without errors.