Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Update stripe-react-native to 0.18.1 to fix compilation errors in Xcode 14 #19055

Merged
merged 1 commit into from Sep 13, 2022

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Sep 9, 2022

Why

It's not possible to build Expo Go with Xcode 14, because of this issue in Stripe iOS: stripe/stripe-ios#1973
Newer version of @stripe/stripe-react-native already contains this fix.

How

  • et uvm -m @stripe/stripe-react-native -c v0.18.1 -p ios
  • Backported Stripe version to older SDKs to avoid version conflicts in CocoaPods
  • rm -rf ios/vendored/unversioned/@stripe/stripe-react-native/ios/Tests to exclude test specs (I'll automate that separately)
  • Updated root changelog

Test Plan

Expo Go builds in Xcode 14 without errors.

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Sep 9, 2022
@tsapeta tsapeta force-pushed the @tsapeta/update-stripe branch 4 times, most recently from f394898 to db72ff0 Compare September 13, 2022 13:47
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 4130903

@tsapeta tsapeta marked this pull request as ready for review September 13, 2022 14:46
@tsapeta tsapeta requested a review from Kudo September 13, 2022 14:46
@tsapeta tsapeta changed the title Update stripe-react-native to 0.18.1 to fix compilation errors in Xcode 14 [ios] Update stripe-react-native to 0.18.1 to fix compilation errors in Xcode 14 Sep 13, 2022
@tsapeta tsapeta merged commit 5effe4e into main Sep 13, 2022
@tsapeta tsapeta deleted the @tsapeta/update-stripe branch September 13, 2022 15:10
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
@Borduhh
Copy link

Borduhh commented Sep 28, 2022

Do we have an ETA of when this will be released, and is there anything we can do to help? We, like many, are deadlocked right now with builds failing because of Stripe.

@tsapeta
Copy link
Member Author

tsapeta commented Sep 28, 2022

@Borduhh
This PR upgraded Stripe in the Expo Go app, so it wouldn't help too much anyway.

You can already just upgrade @stripe/stripe-react-native in your app to the newer version and that should just work. Expo CLI will probably warn that you're using an incompatible version, but in that case you can just ignore it.

If you're using EAS Build, I also recommend using the default image (not latest). The default images for SDK45 and SDK46 use Xcode 13, so it would still compile fine.

@Borduhh
Copy link

Borduhh commented Sep 28, 2022

@Borduhh This PR upgraded Stripe in the Expo Go app, so it wouldn't help too much anyway.

You can already just upgrade @stripe/stripe-react-native in your app to the newer version and that should just work. Expo CLI will probably warn that you're using an incompatible version, but in that case you can just ignore it.

If you're using EAS Build, I also recommend using the default image (not latest). The default images for SDK45 and SDK46 use Xcode 13, so it would still compile fine.

THANK YOU! I think at one point we needed to use the latest tag, but never looked at the eas.json file ever again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants