[tools] Fix transforming binary files #19251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/tools/fix-transforming-binary-files
branch
from
1110cef
to
5179cc5
Compare
Kudo
reviewed
Sep 26, 2022
tsapeta
force-pushed
the
@tsapeta/tools/fix-transforming-binary-files
branch
from
5179cc5
to
8eee411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
copyFileWithTransformsAsyncin expotools doesn't work properly on binary files. We're reading file contents as utf8-encoded and then writing it as utf8-encoded which may break binary files (e.g. images).How
When there are no transforms to apply on the file (I assume binary files are not touched by any transform rule), it's safer to copy existing file to the new location rather than writing as utf8-encoded file.
Test Plan
When I tried to upgrade stripe-react-native on both platforms (#19055), I hit the problem on Android that the images were broken after vendoring. This fixed the issue.