New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(expo-module-scripts): bump config plugins to Node 14 #18204
chore(expo-module-scripts): bump config plugins to Node 14 #18204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kinda against marking this change as a breaking change and in general the impact of changes in config plugins on the package version.
From the user perspective, there is no change in the API of the package and these packages are intended to be used on mobile devices and not in Node. Users don't run this code directly, so it should be the Expo CLI that enforces the Node version, not the individual package. On EAS we're good since it uses Node 16 by default now.
If the config plugin of X
was a separate package, would you bump major version of X
when the new version of the plugin is out?
Another thing I don't like here is that we've just published packages for SDK46 (some of them involving breaking changes and so major bumps) and now, after a few days, we would have to bump them again. If we really need to do breaking changes, it's always better to batch them and release at once. Personally, I don't trust packages that release major versions that often.
cc @brentvatne
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but we may want to support Active LTS instead of Maintenance LTS. Node 18 Maintenance LTS runs until April 2025 and Node 22 will probably be out by then.
this seems fine to me. i'm not super concerned about bundling this in the release but i understand @tsapeta's concern given that we did already do a major version bump in some places. @EvanBacon maybe we can merge this to main after we cut the sdk-46 branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's ship this now that sdk 46 is wrapped up
* chore: bump plugins to node 14 * chore: recompile with Node 14 * chore: changelog
Why
How
et cp --no-test --fix-lint --no-uniformity-check -a
to rebuild packages.