[packages] unify TSConfig package version #19671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
Kudo
reviewed
Oct 24, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Simek
force-pushed
the
@simek/packages-use-tsconfig14
branch
from
ad63c3b
to
cfbdc15
Compare
Kudo
approved these changes
Oct 24, 2022
lukmccall
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Refs #18204
Refs #19670
How
This PR aims to unify the
@tsconfig/nodepackage used version across the workspace.One more dependency which uses
@tsconfig/node12is@expo/rudder-sdk-node, but I have opted-out updating this one, since I'm not sure what's in the future for this package. Let me know if I also should bump this one.Test Plan
Modified packages have been build correctly, also tests seems to do not yield any errors.
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).