Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web][docs] Update progressive-web-apps.md #10311

Closed
wants to merge 1 commit into from

Conversation

joshpaulchan
Copy link

Escape the bars on the table description to fix the table content.

Why

I saw the content was broken while reading it, so I figured I'd fix it.

How

Haven't tested this yet really, besides GH's rich markdown preview.

Test Plan

  • TBD, will follow contributing guidelines

Escape the bars on the table description to fix the table content
@barthap
Copy link
Contributor

barthap commented Sep 23, 2020

I'm afraid it won't work this way because of this issue mdx-js/mdx#838 😞

It may work by replacing the ` backtick with <code> but it won't be the nicest solution.

To check if it's working, do cd docs && yarn && yarn dev and open http://localhost:3000 in browser.

EDIT: A workaround would be replacing the | character with another one looking the same, see this answer.

@joshpaulchan
Copy link
Author

@barthap thanks for letting me know! I hadn't gotten around to testing it but disappointing this wouldn't work. I'm not opposed to migrating the pipe to another character/token since I think that's the simplest solution - any suggestions? or ?

@barthap
Copy link
Contributor

barthap commented Oct 2, 2020

Hi @joshpaulchan,

Please look at #10499 and #10500 if you're still interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants