New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Tables which has a pipe in a code are broken #10499
Comments
We've merged a partial fix (#10500) but it looks like a bug with MDX still causes botched rendering, it's just less botched now (you can figure out what to do, it just looks broken). |
#10311 is related https://docs.expo.io/versions/v39.0.0/sdk/app-auth/#tokenresponse is also affected |
To fix this issue fully, we probably have to wait until remarkjs/remark#536 is merged and released. It's an issue within remark's internals. Until then, we can do two things:
In the example below, the first line has the divisor character and second line has In code, it looks like:
@ide Which one do you prefer? I think 1 is the simplest solution, but also might be too confusing for people to contribute with. 2 is very expressive and increases the code (decreases readability from markdown). Either way, this would solve our current issue until the fix is released. Edit: talked with Cruzan, option 2 seems like the most sensible one in this case. |
I agree the second option is better. The issue is non-obvious and needs to be communicated instead of hidden behind a different unicode character since this is text that people type. The divisor character would make sense to me if it were autogenerated on each build and never typed by people, but otherwise no one is going to know they need to type it. Also it presumably breaks copy/pasting from the docs. |
It’s not remark internals. It’s MDX internals |
SSIA. The
|
in the code (`) is recognized as a table separator.code:
capture:
page: https://docs.expo.io/versions/v39.0.0/sdk/google/
This was caused by #10177 . MDX v1 is GFM compliant, and GFM has same problem.
this can be solved with escaping the pipe in GFM.
string | undefined
but, in the MDX v1.6.18,
\
is remaining.This is MDX's issue. mdx-js/mdx#1285
workaround
revert #10177 😢
The text was updated successfully, but these errors were encountered: