Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork #661

Merged
merged 1 commit into from Oct 22, 2020
Merged

patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork #661

merged 1 commit into from Oct 22, 2020

Conversation

temoto
Copy link
Member

@temoto temoto commented Oct 21, 2020

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.

@temoto temoto linked an issue Oct 21, 2020 that may be closed by this pull request
maximum recursion depth exceeded error in monkey_patch #660
Closed
@temoto
Copy link
Member Author

temoto commented Oct 21, 2020

Guys I tried to create test, was hoping for trigger if os/threading was previously imported or double execute anything, but no luck. Maybe pytest does something wonderful. Can't put too much time into this. But I need working python-sentry :-)

@temoto temoto added platform-python2 Related only to deprecated Python2.7 importance-bug labels Oct 21, 2020
jstasiak
jstasiak reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jstasiak jstasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

eventlet/patcher.py Outdated
@@ -229,7 +231,6 @@ def monkey_patch(**on):

It's safe to call monkey_patch multiple times.
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal (and and #_os = original('os') line above) would be better left out of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it even broke pep8 checker. Sorry, wasn't careful after trying random stuff with testing.

eventlet/patcher.py Outdated Show resolved Hide resolved
@temoto temoto force-pushed the register-at-fork-v2 branch 2 times, most recently from 699c48b to 0a5eee2 Compare October 21, 2020 09:22
temoto
temoto commented Oct 21, 2020
View reviewed changes
eventlet/patcher.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited

Codecov Report

Merging #661 into master will increase coverage by 0%.
The diff coverage is 57%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #661   +/-   ##
======================================
  Coverage      44%     44%           
======================================
  Files          87      87           
  Lines       11843   11848    +5     
  Branches     1779    1779           
======================================
+ Hits         5276    5280    +4     
- Misses       6165    6166    +1     
  Partials      402     402
Flag Coverage Δ
#ipv6 16% <57%> (+<1%) ⬆️
#py27epolls 56% <57%> (-1%) ⬇️
#py27poll 56% <57%> (+<1%) ⬆️
#py27selects 55% <57%> (+<1%) ⬆️
#py35epolls 49% <57%> (+<1%) ⬆️
#py35poll 49% <57%> (+<1%) ⬆️
#py35selects 49% <57%> (+<1%) ⬆️
#py36epolls 49% <57%> (+<1%) ⬆️
#py36poll 49% <57%> (+<1%) ⬆️
#py36selects 49% <57%> (+<1%) ⬆️
#py37epolls 49% <28%> (+<1%) ⬆️
#py37poll 49% <28%> (-1%) ⬇️
#py37selects 49% <28%> (+<1%) ⬆️
#py38epolls 41% <40%> (+<1%) ⬆️
#py38poll 41% <40%> (-1%) ⬇️
#py38selects 40% <40%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
eventlet/patcher.py 33% <57%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a64cea...7a8c83d. Read the comment docs.

@temoto temoto marked this pull request as draft October 22, 2020 01:40
@temoto temoto force-pushed the register-at-fork-v2 branch 2 times, most recently from 9f4c3d6 to 55b0698 Compare October 22, 2020 05:30
@temoto
patcher: [py27] recursion error in pytest/python2.7 installing regist…
7a8c83d 
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
@temoto temoto marked this pull request as ready for review October 22, 2020 07:13
@temoto temoto merged commit 7a8c83d into master Oct 22, 2020
@temoto temoto deleted the register-at-fork-v2 branch October 22, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstasiak jstasiak jstasiak approved these changes

@tipabu tipabu Awaiting requested review from tipabu

Assignees
No one assigned
Labels
importance-bug platform-python2 Related only to deprecated Python2.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maximum recursion depth exceeded error in monkey_patch
3 participants
@temoto @jstasiak @tipabu