Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maximum recursion depth exceeded error in monkey_patch #660

Closed
lobsterkatie opened this issue Oct 20, 2020 · 2 comments · Fixed by #661
Closed

maximum recursion depth exceeded error in monkey_patch #660

lobsterkatie opened this issue Oct 20, 2020 · 2 comments · Fixed by #661

Comments

@lobsterkatie
Copy link

Hello!

This PR, merged yesterday, removed a version check on Python, and now running under 2.7 (which we do as part of our test suite) throws this error:

_______ ERROR at setup of test_transport_works[eventlet-True-close-True] _______
tests/conftest.py:292: in maybe_monkeypatched_threading
    eventlet.monkey_patch()
.tox/py2.7/lib/python2.7/site-packages/eventlet/patcher.py:316: in monkey_patch
    _os = original('os')
.tox/py2.7/lib/python2.7/site-packages/eventlet/patcher.py:201: in original
    real_mod = __import__(modname, {}, {}, modname.split('.')[:-1])
.tox/py2.7/lib/python2.7/fnmatch.py:40: in fnmatch
    import os
.tox/py2.7/lib/python2.7/fnmatch.py:40: in fnmatch
    import os
E   RuntimeError: maximum recursion depth exceeded in __instancecheck__
!!! Recursion detected (same locals & position)

That version check was added here. Is it incompatible with the change made yesterday, or could it be added back in?

Thanks!
@lobsterkatie lobsterkatie mentioned this issue Oct 20, 2020
Merged
lobsterkatie added a commit to getsentry/sentry-python that referenced this issue Oct 20, 2020
@lobsterkatie
fix(dev): Pin eventlet version (#880)
4fab6df 
See eventlet/eventlet#660.
temoto added a commit that referenced this issue Oct 21, 2020
@temoto
patcher: [py27] recursion error in pytest/python2.7 installing regist…
0ba39aa 
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
@temoto temoto mentioned this issue Oct 21, 2020
Merged
@temoto temoto linked a pull request Oct 21, 2020 that will close this issue
patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork #661
Merged
temoto added a commit that referenced this issue Oct 21, 2020
@temoto
patcher: [py27] recursion error in pytest/python2.7 installing regist…
699c48b 
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 21, 2020
@temoto
patcher: [py27] recursion error in pytest/python2.7 installing regist…
0a5eee2 
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 22, 2020
@temoto
patcher: [py27] recursion error in pytest/python2.7 installing regist…
9f4c3d6 
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 22, 2020
@temoto
patcher: [py27] recursion error in pytest/python2.7 installing regist…
55b0698 
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
temoto added a commit that referenced this issue Oct 22, 2020
@temoto
patcher: [py27] recursion error in pytest/python2.7 installing regist…
7a8c83d 
…er_at_fork

#660
getsentry/sentry-python#880

Could not reproduce problem without pytest, so normal production code was probably safe.
@temoto
Copy link
Member

temoto commented Oct 22, 2020

Fixed in 0.29.1

@temoto temoto mentioned this issue Oct 22, 2020
Merged
@lobsterkatie
Copy link
Author

Thanks for the quick turn-around!

bors bot added a commit to duckinator/parts.horse that referenced this issue Oct 24, 2020
@bors @pyup-bot
Merge #68
f1e0fa4 
68: Update eventlet to 0.29.1 r=duckinator a=pyup-bot


This PR updates [eventlet](https://pypi.org/project/eventlet) from **0.28.0** to **0.29.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 0.29.1
   ```
   ======
patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork eventlet/eventlet#660
patcher: monkey_patch(builtins=True) failed on py3 because `file` class is gone eventlet/eventlet#541
don&#39;t crash on PyPy 7.0.0 eventlet/eventlet#547
Only install monotonic on python2 eventlet/eventlet#583
   ```
   
  
  
   ### 0.29.0
   ```
   ======
* ssl: context wrapped listener fails accept() eventlet/eventlet#651
   ```
   
  
  
   ### 0.28.1
   ```
   ======
* Sorry, Eventlet was broken on Windows for versions 0.27-0.28
  patcher: no os.register_at_fork on Windows (654)
* Clean up TypeError in __del__
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/eventlet
  - Changelog: https://pyup.io/changelogs/eventlet/
  - Homepage: http://eventlet.net
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patcher: [py27] recursion error in pytest/python2.7 installing register_at_fork eventlet/eventlet
2 participants
@temoto @lobsterkatie