Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump docker images to z3 4.8.12 #11672

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Bump docker images to z3 4.8.12 #11672

merged 1 commit into from
Jul 26, 2021

Conversation

leonardoalt
Copy link
Member

@leonardoalt leonardoalt commented Jul 16, 2021 •
edited

After these are built, their hashes will be used in the PR that updates the SMTChecker tests. When those tests pass, we can merge this.

@leonardoalt leonardoalt marked this pull request as draft July 16, 2021 09:06
@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-7 [solbuildpackpusher/solidity-buildpack-deps@sha256:b39632393dee57ce1a07c505c094007e853b8ba16076b8d9e66fc69c6922fb70].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004.clang-7 [solbuildpackpusher/solidity-buildpack-deps@sha256:dea7a04ae75bbc00ea6a6e1b802bc53de95d4a30a43c38e45ae0d6c8bdae7195].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu1604.clang.ossfuzz-10 [solbuildpackpusher/solidity-buildpack-deps@sha256:ea15a35f6188360b425593c83e946660ab4ea4dac9b9c3bb3629e6ed57276b1d].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:emscripten-6 [solbuildpackpusher/solidity-buildpack-deps@sha256:092da5817bc032c91a806b4f73db2a1a31e5cc4c066d94d43eedd9f365df7154].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004.clang-7 [solbuildpackpusher/solidity-buildpack-deps@sha256:b175b9bf172341b3e2a1f3f64940983cc60d471fd709cf75ed1d0a93e5fa636e].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-7 [solbuildpackpusher/solidity-buildpack-deps@sha256:af5a0c6ea5e113e477f5387955a862f9aea5cc74d9ceeb2377fc64e64088d200].

cameel
cameel previously approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

scripts/docker/buildpack-deps/Dockerfile.ubuntu2004
@@ -37,7 +37,7 @@ RUN set -ex; \
cmake ninja-build \
libboost-filesystem-dev libboost-test-dev libboost-system-dev \
libboost-program-options-dev \
libcvc4-dev libz3-static-dev \
libcvc4-dev libz3-static-dev z3-static \
; \
apt-get install -qy python3-pip python3-sphinx; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If another rebuild happen to be needed for any reason, could you also remove Sphinx from here?

Suggested change
apt-get install -qy python3-pip python3-sphinx; \
apt-get install -qy python3-pip; \

Related to #11662 (comment). Our docs.sh script reinstalls Sphinx anyway. This installs an ancient version (1.8.5, latest is 4.1.0) which actually causes problems because pip does not by default update packages if they're already installed. I wanted to change it myself but my PR fixes the problem in a different way so it's not strictly required. Still, would be nice not to have this package here any more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. python3-pip is still needed. It's just Sphinx that's superfluous.

@leonardoalt
Copy link
Member Author

Since we're at it, I can just push that one again.

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004.clang-7 [solbuildpackpusher/solidity-buildpack-deps@sha256:cb504c6456d4a2dd80b354acfd7429836da5acce4e394500c02d5740617f9d01].

@cameel
Copy link
Member

cameel commented Jul 16, 2021

Thanks!

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-7 [solbuildpackpusher/solidity-buildpack-deps@sha256:fc735e216b818558af398248d5680d82e579661b88c29ce68b191e93c15b0925].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu1604.clang.ossfuzz-10 [solbuildpackpusher/solidity-buildpack-deps@sha256:01c7eb875157ddcd7b010f53b679afbf32973d29dd86d8e306f5249c13610b00].

@github-actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:emscripten-6 [solbuildpackpusher/solidity-buildpack-deps@sha256:7d49ccbcdfc7dfbedfbd44c31f452f8d1e5f55b873de225ade24779fe25aafb8].

@leonardoalt leonardoalt mentioned this pull request Jul 17, 2021
Merged
@leonardoalt
Copy link
Member Author

@chriseth can you merge this?

@leonardoalt leonardoalt marked this pull request as ready for review July 26, 2021 12:11
@leonardoalt leonardoalt merged commit f697b34 into develop Jul 26, 2021
@leonardoalt leonardoalt deleted the z3_12_docker branch July 26, 2021 12:12
@cameel cameel mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leonardoalt @cameel