-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SMTChecker tests with z3 4.8.12 #11673
Conversation
d0f9a6b
to
bd72841
Compare
bd72841
to
b246d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of counterexamples seem to have disappeared. I that supposed to happen?
@@ -10,6 +10,4 @@ contract C { | |||
// ==== | |||
// SMTEngine: all | |||
// ---- | |||
// Warning 1218: (178-224): CHC: Error trying to invoke SMT solver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the new z3 helps in some cases.
@cameel disappeared in what way? I had to remove a bunch because the MacOS version gives many different results compared to the Linux ones, very annoying... |
Like this: - // Warning 6328: (183-202): CHC: Assertion violation happens here.\nCounterexample:\ns1 = {x: 2, t: {y: 3, a: []}, a: [], ts: []}\n\nTransaction trace:\nC.constructor()\nState: s1 = {x: 0, t: {y: 0, a: []}, a: [], ts: []}\nC.f()
+ // Warning 6328: (183-202): CHC: Assertion violation happens here. |
Yea I had to remove many of those because MacOS is different. |
c67e58e
to
36aa71c
Compare
@cameel |
Which is weird because it doesn't fail for #11672 |
Oh. The problem is that the docs produce quite a lot of warnings right now and Sorry, I did not take that into account. In that case I see 2 solutions:
|
By the way, it does not fail in #11672 because there CI does not yet use the new images (it still has the old hashes). |
36aa71c
to
e46abd0
Compare
# solbuildpackpusher/solidity-buildpack-deps:emscripten-5 | ||
default: "solbuildpackpusher/solidity-buildpack-deps@sha256:d28afb9624c2352ea40f157d1a321ffac77f54a21e33a8e8744f9126b780ded4" | ||
# solbuildpackpusher/solidity-buildpack-deps:emscripten-6 | ||
default: "solbuildpackpusher/solidity-buildpack-deps@sha256:092da5817bc032c91a806b4f73db2a1a31e5cc4c066d94d43eedd9f365df7154" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see these are not the most recent hashes. I guess still the ones from before the sphinx change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, except ubuntu2004-clang which I removed z3-static
again
No description provided.