core/evm: Random opcode (EIP-4399) #24068
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements EIP-4399, the RANDOM opcode post-merge.
Since we don't know the merge block number beforehand, we need to somehow signal to the EVM that the Random opcode should be used now. For that I've implemented the
SetVMConfig
method. Since the transition can happen both during block insertion over the API and during the sync, I needed to add a lock for thevmConf
. Might not be the greatest way to do it (suggestions very welcome). I also pass thevmConf
by value now, not by reference as it is dereferenced in all callers anyway.Additionally I extended the StateTestUtil to be able to create state tests with the RANDOM opcode. An example for that later.
replaces #23985