crypto/cloudflare/bn256: fix in-place addition and unmarshalling #23419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| m := p.Add(p, p).Marshal() | ||
| if _, err := p.Unmarshal(m); err != nil { | ||
| t.Fatalf("p.Add(p, p) ∉ G₂: %v", err) |
There was a problem hiding this comment.
That error message is a bit crazy imo
|
For reference: https://github.com/cloudflare/bn256/pull/12/files |
|
@gballet for some reason I can't find this PR in the travis build history, can you maybe rebase it to trigger travis again? |
gballet
force-pushed
the
bn256-g2-inplace-addition
branch
from
3b1e6cf
to
d64771e
Compare
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 25, 2021
reds
pushed a commit
to reds/go-ethereum
that referenced
this pull request
Aug 28, 2021
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
wgr523
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jan 18, 2024
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23346
There were two upstream fixes required: one is for in-place addition and the second one was for in-place unmarshalling