XDC-01 | Potential Missed Fixings in crypto Module
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#18419) The z == 0 check is hit whenever we Add two points with the same x1/x2 coordinate. crypto/elliptic uses the same check in their affineFromJacobian function. This change does not affect block processing or tx signature verification in any way, because it does not use the Add or Double methods.
…ethereum#19609) * Added checks for nil pointers in Marshal functions * Set nil pointer to identity in GT before marshaling
* crypto/cloudflare: fix nil deref in random G1/G2 reading * crypto/bn256: improve fuzzer * crypto/bn256: fix some flaws in fuzzer
When using -buildmode=shared, R15 is clobbered by a global variable access; use a different register instead. Fixes: ethereum#24439
wgr523
requested review from
wjrjerome,
liam-lai,
GalaxySciTech,
fishermanymc and
wanwiset25
wjrjerome
approved these changes
Jan 20, 2024
liam-lai
approved these changes
Jan 22, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In go-ethereum, there is a list of edge cases or compilation-related issues fixed in the crypto module:
crypto/secp256k1: add checking z sign in affineFromJacobian
crypto: added checks for nil pointers in Marshal functions
crypto/bn256: improve bn256 fuzzer
crypto/cloudflare/bn256: fix in-place addition and unmarshalling
crypto/bn256/cloudflare: fix asm for dynamic linking
We fix these known issues to improve the robustness of the system.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that