Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer: move types to separate package #23275

Merged
merged 2 commits into from Jul 29, 2021
Merged

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jul 27, 2021

Follow-up to #23274 . This PR moves (some) account types into a standalone package, to make the external package not depend on the full signer core package.

This is in reference to #23046

@holiman holiman changed the title Standalone signer: move types to separate package Jul 27, 2021
@fjl fjl merged commit 295bc35 into ethereum:master Jul 29, 2021
@fjl fjl added this to the 1.10.7 milestone Jul 29, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 1, 2021
This PR moves (some) account types into a standalone package, to avoid
depending on signer/core from accounts/external.
reds pushed a commit to reds/go-ethereum that referenced this pull request Aug 28, 2021
This PR moves (some) account types into a standalone package, to avoid
depending on signer/core from accounts/external.
i-norden pushed a commit to cerc-io/go-ethereum that referenced this pull request Sep 10, 2021
This PR moves (some) account types into a standalone package, to avoid
depending on signer/core from accounts/external.
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
This PR moves (some) account types into a standalone package, to avoid
depending on signer/core from accounts/external.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants