Allow to compile client to webassembly #23046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
accounts/abi/bind/auth.go does not compile because it depends on accounts/external, which depends on signer/core, which does not compile under WebAssembly. We will fix it by removing the dependency on signer/core. |
|
The dependency is now removed. |
holiman
reviewed
Aug 3, 2021
Comment on lines
+17
to
+18
| // +build !js | ||
|
|
There was a problem hiding this comment.
This should no longer be needed, after the change in #23275
There was a problem hiding this comment.
Unfortunately this change wasn't enough, here is what I get:
imports github.com/ethereum/go-ethereum/accounts/abi/bind
imports github.com/ethereum/go-ethereum/accounts/external
imports github.com/ethereum/go-ethereum/signer/core/apitypes
imports github.com/ethereum/go-ethereum/internal/ethapi
imports github.com/ethereum/go-ethereum/consensus
imports github.com/ethereum/go-ethereum/core/state
imports github.com/VictoriaMetrics/fastcache
imports golang.org/x/sys/unix: build constraints exclude all Go files in /home/maxmati/go/pkg/mod/golang.org/x/sys@v0.0.0-20210510120138-977fb7262007/unix
I don't know go-ethereum at all so it's hard to fix for me.
We try to use ethereum contract in webassembly but it was failing due to some symbols missing. To fix this I disabled compilation of some modules for js tag.
maxmati
force-pushed
the
BP-3079-clien-compile-wasm
branch
from
d1a02bb
to
03e02c2
Compare
|
We have merged another update to remove more dependencies of accounts/abi/bind, it should compile now. |
|
Since I can't edit this PR, I have re-sent the metrics change in #23449. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to use ethereum contract in webassembly but it was failing due to
some symbols missing. To fix this I disabled compilation of some modules
for js tag.