Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: add item into 3.6 for the fix on panic in readonly serializable txn #14476

Closed
wants to merge 1 commit into from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Sep 16, 2022

cc @spzala @serathius @mitake

Refer to #14110 and #14149

Signed-off-by: Benjamin Wang wachao@vmware.com

…zable txn

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #14476 (6a4c379) into main (2fa7302) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14476      +/-   ##
==========================================
- Coverage   75.39%   75.21%   -0.18%     
==========================================
  Files         457      457              
  Lines       37213    37213              
==========================================
- Hits        28057    27991      -66     
- Misses       7390     7452      +62     
- Partials     1766     1770       +4     
Flag Coverage Δ
all 75.21% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/leasing/util.go 91.66% <0.00%> (-6.67%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 73.43% <0.00%> (-4.17%) ⬇️
server/storage/mvcc/watchable_store.go 84.42% <0.00%> (-3.99%) ⬇️
client/v3/experimental/recipes/key.go 75.34% <0.00%> (-2.74%) ⬇️
server/etcdserver/api/v3rpc/watch.go 85.28% <0.00%> (-2.35%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-1.67%) ⬇️
client/v3/leasing/kv.go 89.70% <0.00%> (-1.67%) ⬇️
server/etcdserver/api/v3rpc/key.go 82.19% <0.00%> (-1.37%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought. Is having all bug fixes present in changelog for minor release unnecessary?

Should changelog for v3.6.0 describe changes from v3.5.0 or latest v3.5.X release? I think option 2 makes more sense. For example:

  • v3.5.5 changelog lists changes from v3.5.4
  • v3.6.0 changelog lists changes from v3.5.5

Approving this PR as it follows currently established process.

@ahrtr
Copy link
Member Author

ahrtr commented Sep 16, 2022

Just a thought. Is having all bug fixes present in changelog for minor release unnecessary?

I don't think we have hard limitation. But convention is to link to PRs instead of issues, and it looks good to me.

Should changelog for v3.6.0 describe changes from v3.5.0 or latest v3.5.X release? I think option 2 makes more sense.

It's a good point. I agree with you. The rules should be:

  1. Each patch release should only include change against previous patch, such as 3.5.4 vs 3.5.5.
  2. For the first release (e.g. 3.6.0) for each minor version, we should only describe new features or changes which are not included in any releases in previous minor version.

So Proposed action:

  1. Remove all bug fix items from changelog-3.6. Of course, if the bug fix only applies to main/3.6, then we need to keep it.

What do you think? @serathius @spzala

@ahrtr
Copy link
Member Author

ahrtr commented Sep 16, 2022

Just raised a separate PR to cleanup changelog 3.6. #14480

So closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants