Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-3.5: server/etcdmain: add configurable cipher list to gRPC proxy listener #14500

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

dusk125
Copy link
Contributor

@dusk125 dusk125 commented Sep 21, 2022

This is a backport of #14308

@ahrtr
Copy link
Member

ahrtr commented Sep 26, 2022

Please fix the fmt & test error.

Usually we only backport bug fix to stable release, but exposing secure ciphers is a common and important part of any service, so It's OK to backport it.

@ahrtr
Copy link
Member

ahrtr commented Sep 26, 2022

Please also remove the CHANGELOG item from 3.6 and add a new item for changelog-3.5. FYI. #14476 (comment)

@dusk125
Copy link
Contributor Author

dusk125 commented Sep 26, 2022

Changelog PR here. Quick question, I'm planning on backporting this change to 3.4, should I just wait to update the changelog until I get that PR open, or should we go through this and #14524 and when I have the 3.4 PR just open another for moving the changelog item from 3.5 to 3.4?

@ahrtr
Copy link
Member

ahrtr commented Sep 26, 2022

  1. It's OK to backport this PR to both 3.5 and 3.4 to me, but we still need other maintainers' approval.
  2. Based on Changelog: add item into 3.6 for the fix on panic in readonly serializable txn #14476 (comment) , eventually we need to add changelog items for both 3.4 and 3.5.

@dusk125
Copy link
Contributor Author

dusk125 commented Sep 29, 2022

  1. It's OK to backport this PR to both 3.5 and 3.4 to me, but we still need other maintainers' approval.
  2. Based on Changelog: add item into 3.6 for the fix on panic in readonly serializable txn #14476 (comment) , eventually we need to add changelog items for both 3.4 and 3.5.

Sounds good, thanks!

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Re-running failed tests.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks both @dusk125 and @spzala

@ahrtr ahrtr merged commit ec6f0a7 into etcd-io:release-3.5 Oct 15, 2022
@ahrtr ahrtr mentioned this pull request Oct 19, 2022
ahrtr added a commit that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants