ci: Upgrade eslint-config-eslint to fix peer conflict #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eslint-config-eslint@6.0.0` has a peer dependency on `eslint-plugin-jsdoc@^15.9.5`, whereas `package.json` has a `devDependency` on `eslint-plugin-jsdoc@^28.6.1`. Those ranges are in conflict. This change upgrades to `eslint-config-eslint@7.0.0`, which changes the peer dependency to `eslint-plugin-jsdoc@>=22.1.0`, resolving the conflict.
|
Weird, I thought that |
mdjermanovic
approved these changes
Jun 20, 2022
|
Agreed, weird. I isolated the behavior change to npm 8.6.0 and above, meaning our CI stopped working when Node 16.15.1 was released. I guess they're still iteration on peer dependency resolution. Maybe it was an unintentional omission that npm wasn't checking this before, and they fixed it like we do in a semver-minor bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-config-eslint@6.0.0has a peer dependency oneslint-plugin-jsdoc@^15.9.5, whereaspackage.jsonhas adevDependencyoneslint-plugin-jsdoc@^28.6.1. Those ranges are in conflict.This change upgrades to
eslint-config-eslint@7.0.0, which changes the peer dependency toeslint-plugin-jsdoc@>=22.1.0, resolving the conflict.This should fix the CI failures seen in #355 and #356. This peer dependency version range conflict was previously being ignored, but a behavior change in npm 8.6.0 started reporting it. Whether that's a backwards-incompatible change in a semver-minor version is left as a question for the reader.