Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2022-06-16 meeting notes (closes #353) #356

Merged
merged 1 commit into from Jun 20, 2022
Merged

Add 2022-06-16 meeting notes (closes #353) #356

merged 1 commit into from Jun 20, 2022

Conversation

btmills
Copy link
Member

@btmills btmills commented Jun 19, 2022

No description provided.

mdjermanovic
mdjermanovic previously approved these changes Jun 19, 2022
View reviewed changes
@mdjermanovic
Copy link
Member

I'm not sure what has changed recently so we're getting errors on npm install in the lint job now.

@btmills
Copy link
Member Author

btmills commented Jun 20, 2022

Oh wow, I recognize that installation failure! I just spent a while debugging two separate behavior changes in recent versions of npm for eslint/eslint-plugin-markdown#206. The Markdown plugin's test setup is a little weird, so I figured we were somehow hitting unsupported behavior. That this repository is also failing leads me to believe there was a regression or intentional breaking change in npm 8.6.0. (8.5.5 shipped with Node 16.12.0. Node 16.12.1 upgraded to npm 8.11.0, but I narrowed down that breakage further to working on Node 16.12.1 with npm 8.5.5 and failing on Node 16.12.1 with npm 8.6.0.)

@btmills btmills mentioned this pull request Jun 20, 2022
Merged
@btmills
Copy link
Member Author

btmills commented Jun 20, 2022

I haven't narrowed it down to a specific commit in npm 8.6.0, but the newly-reported conflict is at least accurate, and I resolved the conflict in #357. Once that's in, I'll rebase this on main.

@btmills
Copy link
Member Author

btmills commented Jun 20, 2022

Rebased, and CI passed! No changes to this diff, but GitHub dismissed the approving review anyway, so re-requesting.

@btmills btmills merged commit c04db90 into main Jun 20, 2022
@btmills btmills deleted the 2022-06-16 branch June 20, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
triage:no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@btmills @mdjermanovic