Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependency shelljs to ^0.8.5 #600

Merged
merged 1 commit into from Apr 25, 2024
Merged

chore: update dependency shelljs to ^0.8.5 #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -51,7 +51,7 @@
"mocha": "^9.2.2",
"npm-run-all": "^4.1.5",
"rollup": "^2.41.2",
"shelljs": "^0.3.0",
"shelljs": "^0.8.5",
"yorkie": "^2.0.0"
},
"keywords": [
Expand Down
7 changes: 4 additions & 3 deletions tests/lib/libraries.js
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ import tester from "./tester.js";
import * as espree from "../../espree.js";
import assert from "assert";
import { fileURLToPath } from "url";
import { readFile } from "fs/promises";

// eslint-disable-next-line no-underscore-dangle -- Conventional
const __dirname = path.dirname(fileURLToPath(import.meta.url));
Expand All @@ -34,9 +35,9 @@ describe("Libraries", () => {

// var filename = "angular-1.2.5.js";

it("should produce correct AST when parsed", () => {
const output = shelljs.cat(`${filename}.result.json`);
const input = shelljs.cat(filename);
Comment on lines -38 to -39
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unit test was failing with a timeout on my macOS dev environment, probably because of the large size of the file tests/fixtures/libraries/angular-1.2.5.js.result.json. After switching to native Node.js API calls, all tests are passing again.

it("should produce correct AST when parsed", async () => {
const output = await readFile(`${filename}.result.json`, "utf-8");
const input = await readFile(filename, "utf-8");
const result = JSON.stringify(tester.getRaw(espree.parse(input, {
ecmaVersion: 5,
loc: true,
Expand Down