chore: update dependency shelljs to ^0.8.5 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
commented
Apr 25, 2024
Comment on lines
-38
to
-39
| const output = shelljs.cat(`${filename}.result.json`); | ||
| const input = shelljs.cat(filename); |
There was a problem hiding this comment.
This unit test was failing with a timeout on my macOS dev environment, probably because of the large size of the file tests/fixtures/libraries/angular-1.2.5.js.result.json. After switching to native Node.js API calls, all tests are passing again.
fasttime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of shelljs prior to v0.8.5 are affected by a high rated security vulnerability. Currently, users working with this repo will have version v0.3.0 installed, since that is the only version that matches the spec ^0.3.0. This PR updates package.json to ensure that only shelljs ^0.8.5 is used.
It also updates a unit test to use native Node.js API to read files.
NVD advisory: https://nvd.nist.gov/vuln/detail/CVE-2022-0144