Fix: Ensure config extends reads from the right spot (fixes #5450) #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
By analyzing the blame information on this pull request, we identified @mysticatea, @SpainTrain and @MethodGrab to be potential reviewers |
| @@ -642,7 +642,7 @@ describe("ConfigFile", function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it("should load information from `extends` chain with relative path.", function() { | |||
| it("should load information from `extends` chain in .eslintrc with relative path.", function() { | |||
There was a problem hiding this comment.
This was a duplicate test name, which caused trouble while I was trying to debug.
|
LGTM |
|
LGTM. Verified manually that it fixes issue with global install. I'm also not sure how to unittest this. |
|
Closing in favor of #6457 |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should fix all of the issues with config
extends. I don't have the energy to figure out a unit test for #6450, but I manually tested on a local copy of Jest (which had reported the problem) and it works. I also verified that #6358 is fixed by this as well.If someone can figure out a good unit test, I'd appreciate it. (I'm guessing we probably just need to pass in something as
relativeTo, I just don't have the extra energy to experiment.)