Regression from 2.13.0 release - relative requires in extend

[hzoo]

Ref #6359 I think, @mysticatea

What version of ESLint are you using?

2.13.0 (just released)

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

{
  "extends": "./node_modules/eslint-preset-behance/.eslintrc"
}

What did you do? Please include the actual source code causing the issue.

run eslint app_folder/

Updated to 2.13.0 in CI

What did you expect to happen?

No issues

What actually happened? Please include the actual, raw output from ESLint.

Cannot read config file: app/node_modules/node_modules/eslint-preset-behance/.eslintrc
Error: ENOENT: no such file or directory, open 'app/node_modules/node_modules/eslint-preset-behance/.eslintrc'

It's checking node_modules/node_modules for some reason

Workaround I guess is that we don't have to use ./node_modules/

[Mardak]

This seems to also result in going up too many parent directories: { "extends": "../../../test/.eslintrc" }

Results in:

Cannot read config file: /Users/test/.eslintrc
Referenced from: /Users/Mardak/foo/bar/baz/test/.eslintrc

Before it would extend /Users/Mardak/foo/test/.eslintrc

[paglias]

Same here. It broke all our builds

[ilyavolodin]

Issue was introduced by #6359 fix.

[hzoo]

for the change: path.join(relativeTo || path.dirname(filePath), parentPath)

parentPath: ./node_modules/eslint-preset-behance/.eslintrc
relativeTo: app/node_modules
path.dirname(filePath): app

path.join(path.dirname(filePath), parentPath)):
app/node_modules/eslint-preset-behance/.eslintrc

path.join(relativeTo, parentPath)):
app/node_modules/node_modules/eslint-preset-behance/.eslintrc

And it looks like the test wasn't testing the change in applyExtends but the input/output of ConfigFile.load

[apazzolini]

This is an issue for me as well. In my instance, this error appears to be related to using eslint as a non-global package and running it with ./node_modules/.bin/eslint

[nzakas]

Let's see what @mysticatea thinks. He should be around soonish and then we can decide whether there's an easy fix or not.

[mysticatea]

I apologize for this.
I will investigate this.
I think relativeTo should be the directory that .eslintrc exists.

[ilyavolodin]

@mysticatea That's what relativeTo should be, but it doesn't look like it is in this case, for some reason. Might be a deeper bug in relativeTo itself (which would affect a lot of other things).

[mysticatea]

Mmm, weird, we also have relative path in our setting and it's working: https://github.com/eslint/eslint/blob/414206cdec53f4967f56ee23ac0c1eb45b31846a/.eslintrc.yml

[mysticatea]

That relativeTo seems to be

eslint/lib/config/config-file.js

Line 328 in 414206c

return path.join(projectPath);

[mysticatea]

load( C:\Users\starc\Documents\GitHub\eslint\.eslintrc.yml undefined undefined )
    resolvedPath: { filePath: 'C:\\Users\\starc\\Documents\\GitHub\\eslint\\.eslintrc.yml' }
    dirname: C:\Users\starc\Documents\GitHub\eslint
    basedir: C:\Users\starc\Documents\GitHub\eslint\node_modules
    lookupPath: C:\Users\starc\Documents\GitHub\eslint\node_modules\node_modules

getBaseDir seems wrong, but if I fixed getBaseDir, I get failures of some tests...

[mysticatea]

Fixed: 4c80417#diff-3ca2712fe1d95b19637e57eb1a8b3a5bR318

But I'm not sure this is a correct way or not...

[nzakas]

I don't think special-casing node_modules is the right approach.

[ljharb]

Is there a deadline at which point the change that broke this will be reverted, absent a fix?

[ilyavolodin]

@ljharb We are usually try to release patches on the following Monday after the release that created an issue.

@mysticatea Another problem related to this change. You can't run global eslint at all anymore:

$ eslint .
Cannot read config file: C:\Users\ilya\AppData\Roaming\npm\node_modules\packages\eslint-config-eslint\default.yml
Error: ENOENT: no such file or directory, open 'C:\Users\ilya\AppData\Roaming\npm\node_modules\packages\eslint-config-eslint\default.yml'
Referenced from: c:\Users\ilya\Documents\github\eslint\.eslintrc.yml
Error: Cannot read config file: C:\Users\ilya\AppData\Roaming\npm\node_modules\packages\eslint-config-eslint\default.yml
Error: ENOENT: no such file or directory, open 'C:\Users\ilya\AppData\Roaming\npm\node_modules\packages\eslint-config-eslint\default.yml'
Referenced from: c:\Users\ilya\Documents\github\eslint\.eslintrc.yml
    at Error (native)
    at Object.fs.openSync (fs.js:549:18)
    at Object.fs.readFileSync (fs.js:397:15)
    at readFile (C:\Users\ilya\AppData\Roaming\npm\node_modules\eslint\lib\config\config-file.js:71:15)
    at loadYAMLConfigFile (C:\Users\ilya\AppData\Roaming\npm\node_modules\eslint\lib\config\config-file.js:102:30)
    at loadConfigFile (C:\Users\ilya\AppData\Roaming\npm\node_modules\eslint\lib\config\config-file.js:219:22)
    at load (C:\Users\ilya\AppData\Roaming\npm\node_modules\eslint\lib\config\config-file.js:500:18)
    at C:\Users\ilya\AppData\Roaming\npm\node_modules\eslint\lib\config\config-file.js:392:36
    at Array.reduceRight (native)
    at applyExtends (C:\Users\ilya\AppData\Roaming\npm\node_modules\eslint\lib\config\config-file.js:363:28)

It's looking for C:\Users\ilya\AppData\Roaming\npm\node_modules\packages\eslint-config-eslint\default.yml and correct path should be C:\Users\ilya\AppData\Roaming\npm\node_modules\eslint\packages\eslint-config-eslint\default.yml
So it's going one directory too far up.

[nzakas]

I think I figured it out. See #6468

[travi]

I'm not sure this fully resolved the problem. I'm still seeing this error in a CI build that shows that it is pulling in the latest version, including this patch.

I started seeing this at the end of last week and have tracked it down to my use of grunt-eslint, which depends on "eslint": "^2.0.0". Therefore, my project does not directly define the eslint version to use since the grunt plugin depends on ^2.0.0

The piece that might be different in my case is that my extends definition is relative to the rule file rather than node_modules: https://github.com/travi/eslint-config-travi/blob/master/rules/tests/react.js#L2

[ljharb]

(This fix did resolve my issue from #6458, fwiw, thanks!!!)

[nzakas]

@travi please open a new issue and provide your details.

[travi]

sure thing: #6489. thank you for the help