Update: Ignore type aliases in space-infix-ops (fixes #10922)

[madbence]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?

space-infix-ops

Does this change cause the rule to produce more or fewer warnings?

No change for javascript, no more false positives for typescript.

How will the change be implemented? (New option, new default behavior, etc.)?

Disable the rule for VariableDeclarators where the parent node is a VariableDeclaration with a non-standard kind (not var, let, or const). After this, eslint-plugin-typescript can implement the rule for typescript type aliases (which are represented as variable declarations, with kind: 'type').

Please provide some example code that this change will affect:

type Foo<T> = T;

What does the rule currently do for this code?

It reports a violation, as after Foo the < is not surrounded by whitespaces.

What will the rule do after it's changed?

It'll ignore typescript type aliases, so a plugin can handle the non-standard syntax.

What changes did you make? (Give an overview)

space-infix-ops will ignore non-standard declarations (everything that's not var, let, or const). a possible fix for #10922

Is there anything you'd like reviewers to focus on?

🤷‍♂️

[platinumazure]

Hi @madbence, thanks for the PR.

Is this change necessary? I think when plugins need to change the behavior of a rule, they usually just reimplement the rule (with the correct behavior for special syntax) and advise users to disable the core rule and enable the plugin rule.

[madbence]

I don't know what would be the correct approach here, to me it feels like that eslint shouldn't try to handle non-standard VariableDeclarators, and the plugin should handle only the syntax-specific stuff (like type aliases).

[madbence]

#10935 resolved the issue, i think i'll close this PR