Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Some space-infix-ops bug #85

Closed
mightyiam opened this issue Oct 9, 2017 · 8 comments
Closed

Some space-infix-ops bug #85

mightyiam opened this issue Oct 9, 2017 · 8 comments

Comments

@mightyiam
Copy link
Contributor

Sorry for submitting it like this, with a screenshot from the IDE. I tried creating a PR with a failing test case. That escalated quickly.

screenshot_2017-10-09_22-19-39

@mightyiam
Copy link
Contributor Author

Is this fixed by now, maybe?

@macklinu
Copy link
Collaborator

space-infix-ops is present in the ESLint core, not this plugin. I'm not sure what the proper next step is, but I would guess that this issue should be opened in the ESLint repo. The only slightly related issue I could find to this (type annotations + space-infix-ops) is eslint/eslint#5211.

@macklinu
Copy link
Collaborator

I'm thinking, based on https://github.com/nzakas/eslint-plugin-typescript/issues/101#issuecomment-372155440, that we'd need to fork the space-infix-ops rule into this plugin and handle this test case.

@zuzusik
Copy link

zuzusik commented Jul 8, 2018

There is also issue in parser for this: eslint/typescript-eslint-parser#486

@madbence
Copy link

madbence commented Oct 5, 2018

I opened eslint/eslint#10922 and eslint/eslint#10923 that can possibly resolve false positives, but it means that a new rule has to be added to eslint-plugin-typescript. as an alternative, typescript-estree could parse type aliases differently, see JamesHenry/typescript-estree#17.

@madbence
Copy link

eslint/eslint#10935 fixed this i think (eslint@5.7.0), can you confirm @mightyiam ?

@mightyiam
Copy link
Contributor Author

Confirmed with eslint@5.8.0.

@mightyiam
Copy link
Contributor Author

Thank you, @madbence.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants