Upgrade to latest eslint and eslint-plugin-react #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new rules to configurations.
This fixes a bug in relative paths that was making our build fail.
| @@ -328,6 +330,8 @@ module.exports = { | |||
| 'max-depth': 1, | |||
| // specify the maximum length of a line in your program | |||
| 'max-len': [1, 80, 2], | |||
| // enforce a maximum file length | |||
| 'max-lines': 0, | |||
There was a problem hiding this comment.
Does 'max-lines': 0 mean there is no maximum, or is this saying the max number of lines is 0? If means the same as it reads, it might be a typo.
There was a problem hiding this comment.
It means this rule is disabled. For all of the rules, a single value means 'off' (0), 'warning' (1), or 'error' (2). If there is configuration, then it goes in an array, where the first element is the same as above, and the remaining values are config.
ESLint recently introduced support for using words instead of numbers; might be a good idea to adopt that at some point to make the config clearer.
There was a problem hiding this comment.
Got it. Thanks for the clarification!
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new rules to configurations.