New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added editor config #464

Merged

kecrily merged 3 commits into main from add-editor-config

Aug 2, 2023

Member

harish-sethuraman commented Aug 1, 2023

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

Adds editor config file to standardise spacing and lf

What changes did you make? (Give an overview)

added editor config file

Related Issues

regarding #461 (review)

harish-sethuraman added 2 commits

August 1, 2023 22:46


          chore: add editor config

eafe0f6


          chore: modify editor config

b9e293a

eslint-github-bot bot commented Aug 1, 2023

Hi @harish-sethuraman!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
There should be a space following the initial tag and colon, for example 'feat: Message'.
The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for new-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/64c9ee18bc86dd0007236b10
😎 Deploy Preview	https://deploy-preview-464--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/64c9ee18826c9700086fde6b
😎 Deploy Preview	https://deploy-preview-464--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for es-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/64c9ee18cc331d00088854f6
😎 Deploy Preview	https://deploy-preview-464--es-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

harish-sethuraman changed the title ~~Add editor config~~ chore: added editor config

eslint-github-bot bot added the chore label

harish-sethuraman self-assigned this

harish-sethuraman added the accepted label

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/64c9ee1837bed5000866ba6a
😎 Deploy Preview	https://deploy-preview-464--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/64c9ee18c07d010008d84ba1
😎 Deploy Preview	https://deploy-preview-464--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/64c9ee18de4c890008731be5
😎 Deploy Preview	https://deploy-preview-464--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/64c9ee18d1341b0007874b0c
😎 Deploy Preview	https://deploy-preview-464--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Aug 1, 2023 •

edited

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`523bdd6`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/64c9ee18f014710008fb918a
😎 Deploy Preview	https://deploy-preview-464--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amareshsm requested a review from kecrily

August 1, 2023 18:12

amareshsm approved these changes

View reviewed changes

Member

amareshsm left a comment

LGTM. Thanks! waiting for @kecrily review.

mdjermanovic approved these changes

View reviewed changes

.editorconfig Outdated Show resolved Hide resolved


          chore: insert final newline

523bdd6

snitin315 approved these changes

View reviewed changes

Contributor

snitin315 left a comment

LGTM, thanks!

kecrily approved these changes

View reviewed changes

Member

kecrily left a comment

LGTM

kecrily merged commit 52ed64d into main

45 checks passed

kecrily deleted the add-editor-config branch

August 2, 2023 14:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment