This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Breaking: drop support for Node < 10 #27
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4b7cd7a
Breaking: drop support for Node < 10
kaicataldo fbc1c5f
Fix ESLint errors
kaicataldo b740cf3
Update failing projects
kaicataldo 9a271bc
Update other failing projects
kaicataldo 2635f59
Test to see what we need to disable
kaicataldo 7b85fc0
Update mocha to SHA that uses latest version of ESLint
kaicataldo 9c4b53c
Update SHAs of other projects
kaicataldo 453be31
Update redux SHA
kaicataldo 3f059ea
Disable failing rules in Vue
kaicataldo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,5 @@ rules: | |
- error | ||
- name: child_process | ||
message: Please use cross-spawn instead. | ||
|
||
no-console: off |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
package-lock = false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
language: node_js | ||
node_js: | ||
- 6 | ||
- 7 | ||
- 10 | ||
- 12 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,14 +9,13 @@ | |
|
||
- name: body-parser | ||
repo: https://github.com/expressjs/body-parser | ||
commit: b2659a7af3b413a2d1df274bef409fe6cdcf6b8f | ||
commit: b15bae549108e613ceb5e408731cbdb374ad62df | ||
args: | ||
- . | ||
- --rule=indent:off | ||
|
||
- name: jquery | ||
repo: https://github.com/jquery/jquery | ||
commit: 3e3b09d68d317a3fe567e377e9032319ac5e0829 | ||
commit: c1ee33aded44051b8f1288b59d2efdc68d0413cc | ||
args: | ||
- src/**/*.js | ||
- Gruntfile.js | ||
|
@@ -25,60 +24,46 @@ | |
|
||
- name: mocha | ||
repo: https://github.com/mochajs/mocha | ||
commit: 09ce746aa925d35317f2624fd36c77a31bb68e24 | ||
commit: 883ae4b5e1aacd8cf30694da33b391ce58f4cca8 | ||
args: | ||
- . | ||
- bin/* | ||
- --rule=indent:off | ||
- --rule=no-multi-spaces:[error,{ignoreEOLComments:true}] | ||
|
||
- name: node | ||
repo: https://github.com/nodejs/node | ||
commit: 0863a0e528ba9ee01f960dce7ffebe8fff3a774c | ||
commit: 7babffbe6054754b733098c52786a23df4049a74 | ||
args: | ||
- --rulesdir=tools/eslint-rules | ||
- benchmark | ||
- lib | ||
- test | ||
- tools | ||
- --rule=indent:off | ||
- --rule=no-multi-spaces:[error, {ignoreEOLComments:true}] | ||
- --rule=timer-arguments:off | ||
- --rule=no-self-assign:[error, {props:false}] | ||
|
||
- name: redux | ||
repo: https://github.com/reactjs/redux | ||
commit: ac7cd32a5270eb374611bf73d072e84a1e7567c2 | ||
commit: 9819b5ef2909cacda0f09c8d29fde229bd7da5fa | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated to ESLint v6 here: reduxjs/redux#3698 |
||
args: | ||
- src | ||
- test | ||
- examples | ||
- --ext js,ts | ||
- src/**/* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This fails without specifying this glob. |
||
- test/**/* | ||
|
||
- name: vue | ||
repo: https://github.com/vuejs/vue | ||
commit: d982e344b39391fe91b6dd91d51b2f0310a45e77 | ||
commit: 6390f70c2e4ec7e51cce1d2a4ba35e2d0d328205 | ||
args: | ||
- src | ||
- build | ||
- scripts | ||
- test | ||
- --rule=indent:off | ||
- --rule=no-multi-spaces:[error,{ignoreEOLComments:true}] | ||
- --rule=camelcase:off # There are several `camelcase` errors in the vue codebase for some reason | ||
# The Vue codebase has some linting errors in master. | ||
- --rule=no-prototype-builtins:off | ||
- --rule=no-redeclare:off | ||
|
||
- name: webpack | ||
repo: https://github.com/webpack/webpack | ||
commit: 95291e83662b2a2a184d492de0451cda27da1279 | ||
commit: 9d907c1c3810577dcbb83aad5fb2bc5de093f2bd | ||
args: | ||
- lib | ||
- bin | ||
- hot | ||
- buildin | ||
- test/*.js | ||
- test/**/webpack.config.js | ||
- examples/**/webpack.config.js | ||
- schemas/**/*.js | ||
- --rule=no-self-assign:[error, {props:false}] | ||
- --rule=node/no-missing-require:off # Prevent missing dependencies from erroring | ||
- --rule=prettier/prettier:off # There are several errors with `prettier/prettier`, need to figure out what is missing in config | ||
- . | ||
# Disabling this rule so that we don't have to install all missing dependencies. | ||
- --rule=node/no-missing-require:off | ||
dependencies: | ||
- prettier |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to ESLint v6 here: mochajs/mocha#4138