This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Breaking: drop support for Node < 10 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
force-pushed
the
update-deps
branch
from
a0bf4b1
to
1cf2578
Compare
kaicataldo
added
dependencies
kaicataldo
force-pushed
the
update-deps
branch
from
1cf2578
to
e8c5792
Compare
kaicataldo
force-pushed
the
update-deps
branch
from
e8c5792
to
fbc1c5f
Compare
mysticatea
previously approved these changes
Dec 24, 2019
platinumazure
previously approved these changes
Dec 26, 2019
kaicataldo
dismissed stale reviews from platinumazure and mysticatea
via
b740cf3
kaicataldo
force-pushed
the
update-deps
branch
from
01e579f
to
2635f59
Compare
13 tasks
kaicataldo
commented
Feb 12, 2020
|
|
||
| - name: redux | ||
| repo: https://github.com/reactjs/redux | ||
| commit: ac7cd32a5270eb374611bf73d072e84a1e7567c2 | ||
| commit: 9819b5ef2909cacda0f09c8d29fde229bd7da5fa |
There was a problem hiding this comment.
Updated to ESLint v6 here: reduxjs/redux#3698
kaicataldo
commented
Feb 12, 2020
| @@ -25,60 +24,42 @@ | |||
|
|
|||
| - name: mocha | |||
| repo: https://github.com/mochajs/mocha | |||
| commit: 09ce746aa925d35317f2624fd36c77a31bb68e24 | |||
| commit: 883ae4b5e1aacd8cf30694da33b391ce58f4cca8 | |||
There was a problem hiding this comment.
Updated to ESLint v6 here: mochajs/mocha#4138
kaicataldo
commented
Feb 12, 2020
projects.yml
Outdated
| - --rule=indent:off | ||
| - --rule=no-multi-spaces:[error,{ignoreEOLComments:true}] | ||
| - --rule=camelcase:off # There are several `camelcase` errors in the vue codebase for some reason | ||
| # - name: vue |
There was a problem hiding this comment.
Waiting on vuejs/vue#11099 to land before we can merge this.
There was a problem hiding this comment.
I decided to disable the failing rules and we can update later on.
kaicataldo
force-pushed
the
update-deps
branch
from
b6c8d89
to
453be31
Compare
kaicataldo
commented
Feb 12, 2020
| - test | ||
| - examples | ||
| - --ext js,ts | ||
| - src/**/* |
There was a problem hiding this comment.
This fails without specifying this glob.
|
This is ready to go! |
btmills
approved these changes
Feb 17, 2020
nzakas
approved these changes
Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to update dependencies and drop support for Node < 10.
Does this seem okay? We could keep support for Node 8, but since it will be out of maintenance mode soon I don't think it's worth it.