New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attach linux arm64 artifact #725
Conversation
Update the build to attach the linux aarch_64 binary as an artifact to the build (so it will be published to Maven repository on deploy) and bump the version of protoc used to generate Java code to 3.21.9 (same version we're pulling it at runtime).
relates to #680 |
@@ -168,7 +168,7 @@ | |||
<version>3.3.0</version> | |||
<executions> | |||
<execution> | |||
<id>osx-x86_64</id> | |||
<id>attach-artifacts</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need separate executions for each architecture - we can just list all artifacts in a single execution.
<artifact> | ||
<file>${project.build.directory}/protoc-gen-validate-${project.version}-linux-aarch_64.exe</file> | ||
<type>exe</type> | ||
<classifier>linux-aarch_64</classifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was what was missing from previous fix - we were building the binary but in order for it to be published you have to attach it as an artifact to the build.
@@ -38,7 +38,7 @@ | |||
<properties> | |||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
|
|||
<protoc.version>3.19.4</protoc.version> | |||
<protoc.version>3.21.9</protoc.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep this in sync with the version below (and there've been security fixes made to this since we last updated).
<url>https://github.com/bufbuild/protoc-gen-validate</url> | ||
<connection>scm:git:git@github.com:bufbuild/protoc-gen-validate.git</connection> | ||
<developerConnection>scm:git:git@github.com:bufbuild/protoc-gen-validate.git</developerConnection> | ||
<tag>HEAD</tag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't really have any effect other than reducing the need to follow redirects.
Update the build to attach the linux aarch_64 binary as an artifact to the build (so it will be published to Maven repository on deploy) and bump the version of protoc used to generate Java code to 3.21.9 (same version we're pulling it at runtime).