attach linux arm64 artifact #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the build to attach the linux aarch_64 binary as an artifact to the build (so it will be published to Maven repository on deploy) and bump the version of protoc used to generate Java code to 3.21.9 (same version we're pulling it at runtime).
|
relates to #680 |
pkwarren
commented
Nov 7, 2022
| @@ -168,7 +168,7 @@ | |||
| <version>3.3.0</version> | |||
| <executions> | |||
| <execution> | |||
| <id>osx-x86_64</id> | |||
| <id>attach-artifacts</id> | |||
There was a problem hiding this comment.
We don't need separate executions for each architecture - we can just list all artifacts in a single execution.
| <artifact> | ||
| <file>${project.build.directory}/protoc-gen-validate-${project.version}-linux-aarch_64.exe</file> | ||
| <type>exe</type> | ||
| <classifier>linux-aarch_64</classifier> |
There was a problem hiding this comment.
This was what was missing from previous fix - we were building the binary but in order for it to be published you have to attach it as an artifact to the build.
| @@ -38,7 +38,7 @@ | |||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
|
|
|||
| <protoc.version>3.19.4</protoc.version> | |||
| <protoc.version>3.21.9</protoc.version> | |||
There was a problem hiding this comment.
We should keep this in sync with the version below (and there've been security fixes made to this since we last updated).
| <url>https://github.com/bufbuild/protoc-gen-validate</url> | ||
| <connection>scm:git:git@github.com:bufbuild/protoc-gen-validate.git</connection> | ||
| <developerConnection>scm:git:git@github.com:bufbuild/protoc-gen-validate.git</developerConnection> | ||
| <tag>HEAD</tag> |
There was a problem hiding this comment.
This shouldn't really have any effect other than reducing the need to follow redirects.
elliotmjackson
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the build to attach the linux aarch_64 binary as an artifact to the build (so it will be published to Maven repository on deploy) and bump the version of protoc used to generate Java code to 3.21.9 (same version we're pulling it at runtime).