Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FloatConvertor regex #1973

Merged
merged 4 commits into from Dec 3, 2022
Merged

Fix FloatConvertor regex #1973

merged 4 commits into from Dec 3, 2022

Commits on Nov 14, 2022

  1. Bugfix of regex at FloatConvertor (version 2) 

    For passing your checks of #1942
A correct statement is: regex = r"[0-9]+(\.[0-9]+)?"
Reference: https://www.flake8rules.com/rules/W605.html

I have no problem to corrected without 'r' prefix directly at /site-packages/starlette/convertors.py of my computer.
Having submitted last pull-request, I realized to add a 'r' prefix to pass your tests.
    @i-Ching
    i-Ching committed Nov 14, 2022
    Copy the full SHA
    020e579 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Add test

    @Kludex
    Kludex committed Dec 3, 2022
    Copy the full SHA
    4cec8fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-2

    @Kludex
    Kludex committed Dec 3, 2022
    Copy the full SHA
    a402931 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into patch-2

    @Kludex
    Kludex committed Dec 3, 2022
    Copy the full SHA
    8d71701 View commit details
    Browse the repository at this point in the history