Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FloatConvertor regex #1973

Merged
merged 4 commits into from Dec 3, 2022
Merged

Fix FloatConvertor regex #1973

merged 4 commits into from Dec 3, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Dec 3, 2022 •
edited

i-Ching and others added 2 commits November 14, 2022 10:45
@i-Ching
Bugfix of regex at FloatConvertor (version 2)
020e579 
For passing your checks of #1942
A correct statement is: regex = r"[0-9]+(\.[0-9]+)?"
Reference: https://www.flake8rules.com/rules/W605.html

I have no problem to corrected without 'r' prefix directly at /site-packages/starlette/convertors.py of my computer.
Having submitted last pull-request, I realized to add a 'r' prefix to pass your tests.
@Kludex
Add test
4cec8fe
@Kludex Kludex changed the title Bugfix of regex at FloatConvertor (version 2) Fix FloatConvertor regex Dec 3, 2022
@Kludex Kludex requested a review from a team December 3, 2022 07:32
@Kludex Kludex added this to the Version 0.23.0 milestone Dec 3, 2022
@Kludex Kludex mentioned this pull request Dec 3, 2022
Merged
1 task
@Kludex Kludex merged commit 865efeb into master Dec 3, 2022
@Kludex Kludex deleted the patch-2 branch December 3, 2022 11:16
aminalaee pushed a commit that referenced this pull request Feb 13, 2023
@Kludex @i-Ching @aminalaee
Fix FloatConvertor regex (#1973)
f2ccd05 
* Bugfix of regex at FloatConvertor (version 2)

For passing your checks of #1942
A correct statement is: regex = r"[0-9]+(\.[0-9]+)?"
Reference: https://www.flake8rules.com/rules/W605.html

I have no problem to corrected without 'r' prefix directly at /site-packages/starlette/convertors.py of my computer.
Having submitted last pull-request, I realized to add a 'r' prefix to pass your tests.

* Add test

Co-authored-by: Ching <thus.kindly@gmail.com>
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-oleshkevich alex-oleshkevich alex-oleshkevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kludex @alex-oleshkevich @i-Ching