Fix TestClient for extra unquote in query parameters (#1952) #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by removing the unquote operations for netloc and query URL parts
Closed
9 tasks
1 task
|
Can confirm that this fixes it. Any plans for merging and releasing this soon? |
Kludex
approved these changes
Nov 16, 2022
|
Gracias @azogue por el PR :) I was thinking: "tonight I'll just watch Netflix", and then I saw @gaborbernat's comment... Since I'm a fan of your work, I got up, and opened my IDE hahaha Thanks for all your open source work. 😁 I'll cook a release in the next minutes. |
|
Much appreciated ❣️ |
aminalaee
pushed a commit
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The starting point for contributions should usually be a discussion
Simple documentation typos may be raised as stand-alone pull requests, but otherwise please ensure you've discussed your proposal prior to issuing a pull request.
This will help us direct work appropriately, and ensure that any suggested changes have been okayed by the maintainers.