Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: UT fails updating python dependencies (starlette) #183

Closed
1 task done
kairoaraujo opened this issue Nov 16, 2022 · 2 comments
Closed
1 task done

Bug: UT fails updating python dependencies (starlette) #183

kairoaraujo opened this issue Nov 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@kairoaraujo
Copy link
Member

What happened?

https://github.com/vmware/repository-service-tuf-api/actions/runs/3477471009/jobs/5813668802

The above error caused Starlette to update to 0.21.0.
For more details, see:

What steps did you take?

No response

What behavior did you expect?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kairoaraujo kairoaraujo added bug Something isn't working needs-triage Needs triage labels Nov 16, 2022
kairoaraujo pushed a commit to kairoaraujo/repository-service-tuf-api that referenced this issue Nov 16, 2022
Pinned starlette and add verbosity to update debs
1de93a5 
- Pinned version for starlette==0.20.4
- Add the diff for the requirement packages
- Update Python Dependencies

It is related to repository-service-tuf#183

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
@kairoaraujo kairoaraujo removed the needs-triage Needs triage label Nov 16, 2022
@kairoaraujo kairoaraujo mentioned this issue Nov 16, 2022
Merged
@kairoaraujo
Copy link
Member Author

We can remove the pinned version when the fix for Starlette is merged and there is a new release.

kairoaraujo added a commit that referenced this issue Nov 16, 2022
@kairoaraujo
Pinned starlette and add verbosity to update debs (#184)
eaab452 
- Pinned version for starlette==0.20.4
- Add the diff for the requirement packages
- Update Python Dependencies

It is related to #183

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
kairoaraujo pushed a commit to kairoaraujo/repository-service-tuf-api that referenced this issue Feb 23, 2023
remove the pinned starlette version
c536857 
It removes the pinned starlette dependency version

This pinned version was applied as a workaround for issue repository-service-tuf#183

The startelle version is updated to the latest version, which fixes a
security issue GHSA-74m5-2c7w-9w3x

The solution requires to install the new `httpx` development
dependency to support the unit tests using the FastAPI TestClient as
described in this link: https://fastapi.tiangolo.com/tutorial/testing/

A workaround needs to be applied to the tests which uses `DELETE`
method.

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
@kairoaraujo kairoaraujo mentioned this issue Feb 23, 2023
Merged
kairoaraujo pushed a commit to kairoaraujo/repository-service-tuf-api that referenced this issue Feb 23, 2023
remove the pinned starlette version
f1dd9ec 
It removes the pinned starlette dependency version

This pinned version was applied as a workaround for issue repository-service-tuf#183

The startelle version is updated to the latest version, which fixes a
security issue GHSA-74m5-2c7w-9w3x

The solution requires to install the new `httpx` development
dependency to support the unit tests using the FastAPI TestClient as
described in this link: https://fastapi.tiangolo.com/tutorial/testing/

A workaround needs to be applied to the tests which uses `DELETE`
method.

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
MVrachev pushed a commit that referenced this issue Feb 27, 2023
@kairoaraujo
remove the pinned starlette version (#270)
3484a58 
* remove the pinned starlette version

It removes the pinned starlette dependency version

This pinned version was applied as a workaround for issue #183

The startelle version is updated to the latest version, which fixes a
security issue GHSA-74m5-2c7w-9w3x

The solution requires to install the new `httpx` development
dependency to support the unit tests using the FastAPI TestClient as
described in this link: https://fastapi.tiangolo.com/tutorial/testing/

A workaround needs to be applied to the tests which uses `DELETE`
method.

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>

* update using `make requirements`

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>

---------

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
kairoaraujo added a commit that referenced this issue Mar 2, 2023
@kairoaraujo
remove the pinned starlette version (#270)
6600df9 
* remove the pinned starlette version

It removes the pinned starlette dependency version

This pinned version was applied as a workaround for issue #183

The startelle version is updated to the latest version, which fixes a
security issue GHSA-74m5-2c7w-9w3x

The solution requires to install the new `httpx` development
dependency to support the unit tests using the FastAPI TestClient as
described in this link: https://fastapi.tiangolo.com/tutorial/testing/

A workaround needs to be applied to the tests which uses `DELETE`
method.

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>

* update using `make requirements`

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>

---------

Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
@kairoaraujo
Copy link
Member Author

Closed by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kairoaraujo