TestClient accepts backend and backend_options as arguments #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Jun 23, 2021
graingert
approved these changes
Jun 23, 2021
JayH5
reviewed
Jun 27, 2021
| @@ -381,13 +381,11 @@ def receive_json(self, mode: str = "text") -> typing.Any: | |||
|
|
|||
| class TestClient(requests.Session): | |||
| __test__ = False # For pytest to not discover this up. | |||
|
|
|||
| #: These options are passed to `anyio.start_blocking_portal()` | |||
| #: These are the default options for the constructor arguments | |||
| async_backend: typing.Dict[str, typing.Any] = { | |||
There was a problem hiding this comment.
Do we need this class-level declaration still? Class vars always confuse me, but this means somebody can do:
TestClient.async_backend["backend"] = "trio"to default all future TestClient instances to use the Trio backend, right?
I know removing this would be slightly changing the API, however in the code examples we gave we only modified instance attributes and that usage should stay the same. What's your thinking around this?
There was a problem hiding this comment.
I've removed it in my followup PR: #1211
|
merged in #1211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented in #1157,
TestClient.async_backendwas a class-level attribute. This made it easy to monkeypatch for use in starlette tests, but makes it difficult/impossible to run different test client backends concurrently (in threads).This PR changes TestClient to accept a
backendandbackend_optionsarguments which allow a user to specify the backend options for only that TestClient instance. The class attribute will remain as the default for these arguments.Fixes #1209