This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
Update requirements on gems #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmahsax
changed the title
added 3 commits
September 8, 2021 22:01
Octokit will resolve that warning and push a new release on their own time... there's no point in this gem specifying to wait for that.
emmahsax
pushed a commit
that referenced
this pull request
Dec 14, 2021
* Remove limiting dependency on psych * Lock down faraday * Remove requirement on Faraday Octokit will resolve that warning and push a new release on their own time... there's no point in this gem specifying to wait for that. * Update version * Oops, don't raise the version too far
emmahsax
added a commit
that referenced
this pull request
Feb 23, 2022
* Remove limiting dependency on psych * Lock down faraday * Remove requirement on Faraday Octokit will resolve that warning and push a new release on their own time... there's no point in this gem specifying to wait for that. * Update version * Oops, don't raise the version too far
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Psych
Now that psych version 4.0.1 has been released, I'm going to trial removing the upper dependency on the psych gem. Perhaps upgrading my machine to 4.0.1 will not result in errors. Previously, I had issues making merge requests (on GitLab) and pull requests (on GitHub), so it seems to be doing better so far. My guess is that git_helper will still not be compatible with psych 4.0.0, so it's now up to each user of git_helper to update their local psych verison.
Faraday
Faraday released version 1.7.1, which ends up resulting in warning messages. We need to wait for 1.7.2 to be released in order to address those. See more here. Although this is something new that I'm finding now, I don't see the value in waiting to release a new version of this gem. When Octokit updates their versions, then each user of git_helper can locally pull a new Faraday version.
Related Pull Requests and Issues
Additional Context