Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Remove using 3rd party gems #67

Merged
merged 7 commits into from
Oct 9, 2021
Merged

Remove using 3rd party gems #67

merged 7 commits into from
Oct 9, 2021

Conversation

emmahsax
Copy link
Owner

@emmahsax emmahsax commented Sep 25, 2021

Changes

Remove the use of 3rd party gems to do API work, such as the Gitlab gem and the Octokit gem. Although it means that there's a bit more code for me to maintain myself, it ends up being more to my benefit. Here's the motivation for this:

  1. The Gitlab gem doesn't really seem to be maintained by the owner, meaning it only gets updates when other people submit pull requests and they're accepted. But, even with that, there's not very many new releases created. I've also seen several places where the gem is using a deprecated version of the GitLab API, which makes me nervous since it doesn't receive updates frequently.
  2. The Octokit gem has a bunch of other dependencies, such as Faraday. And the more gems this project requires, the more gems there are to update regularly. Which means that we're further at the mercy of other gems' bugs and warning deprecations (see the note in Update requirements on gems #65). By removing the Octokit gem, we're no longer seeing the issues with those.

Because there are a lot of changes in this merge request, and they may not all be found in my current testing, I'm going to leave this pull request open for a while. I'm going to build the test gem locally on all of my machines, and use them in my daily coding life for a minimum of two weeks to see if any other bugs pop up that need to be addressed. By the time this is released formally, it should have no changing functionality for users, so it's essentially just a big refactor.

Related Pull Requests and Issues

If applicable, a list of related pull requests and issues:

  • Issue URL link
  • Pull Request URL link

Additional Context

Add any other context about the problem here.

@emmahsax
Copy link
Owner Author

emmahsax commented Oct 9, 2021

At this point, this pull request has been tested on all projects I use regularly, both on GitLab and GitHub. I believe this is good to be merged and released as a new minor version.

@emmahsax emmahsax merged commit 2798d98 into main Oct 9, 2021
@emmahsax emmahsax deleted the remove_external_clients branch October 9, 2021 14:13
emmahsax pushed a commit that referenced this pull request Dec 14, 2021
* Remove the GitLab rubygem client and use raw CURL commands

* Rename Octokit to plain GitHub

* Make asking for MR or PR IDs required

* Add more docs

* Any apostrophe's in the values need to be weirdly double escaped

Here's what the escape pattern must turn into:
Emma's example => Emma'\\''s example

* Empty commit

* Update version file
emmahsax added a commit that referenced this pull request Feb 23, 2022
* Remove the GitLab rubygem client and use raw CURL commands

* Rename Octokit to plain GitHub

* Make asking for MR or PR IDs required

* Add more docs

* Any apostrophe's in the values need to be weirdly double escaped

Here's what the escape pattern must turn into:
Emma's example => Emma'\\''s example

* Empty commit

* Update version file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant