Migrate from libc to rustix. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates terminal_size from using libc directly to using rustix, which eliminates a few unsafe blocks and manual error handling. It does also add one new unsafe block, though this is because `terminal_size_using_fd` is a public safe function that has a `RawFd` argument. With [I/O safety], which is expected to be [stabilized in Rust 1.63], there will be new guidance saying be that [such functions should be unsafe]. It's not urgent to make any changes for this right now though. This also updates the minimum Rust version to 1.48, which is about as old as the previous minimum Rust version was when it was last updated. [I/O safety]: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md [stabilized in Rust 1.63]: rust-lang/rust#87074 [such functions should be unsafe]: https://doc.rust-lang.org/nightly/std/os/unix/io/index.html
|
(@sunfishcode out here, single-handedly upgrading the entire ecosystem to rustix 🎉 ) |
|
Released on crates.io as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates terminal_size from using libc directly to using rustix,
which eliminates a few unsafe blocks and manual error handling.
It does also add one new unsafe block, though this is because
terminal_size_using_fdis a public safe function that has aRawFdargument. With I/O safety, which is expected to be stabilized in Rust 1.63,
there will be new guidance saying be that such functions should be unsafe.
It's not urgent to make any changes for this right now though.
This also updates the minimum Rust version to 1.48, which is about as
old as the previous minimum Rust version was when it was last updated.