Optimize away a call to std::io::stdout().
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this code called `std::io::stdout` just to call `as_raw_fd` on it. But calling `std::io::stdout` involves acquiring a lock, and it doesn't fully optimize away. So instead, call `rustix::io::raw_stdout`, which just returns the stdout file descriptor directly, without taking a lock.
|
Thanks! Published as v0.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code added in #33 called
std::io::stdoutjust to callas_raw_fdon the result. But calling
std::io::stdoutinvolves acquiring a lock,and it doesn't fully optimize away. So instead, call
rustix::io::raw_stdout, which just returns the stdout file descriptordirectly, without doing anything else.
This shaves off 444 bytes of binary size, which is enough to give
terminal-size 0.2 a slightly smaller code-size footprint in release
builds than even terminal-size 0.1.