Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove escapeExpression from @ember/template #20627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Sponsor Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 22, 2024

Co-Authored-By: @chriskrycho

Rebase of: #20360

This also gets a mention here: emberjs/rfcs#1003 馃槄 (for migration docs)

@kategengler
Copy link
Member

If it was private, shouldn't need to be in the RFC, I'd think

@kategengler
Copy link
Member

May have been private but Handlebars.Utils.escapeExpression has uses in addons...

@NullVoxPopuli
Copy link
Sponsor Contributor Author

May have been private but Handlebars.Utils.escapeExpression has uses in addons...

people using private apis should be used to what happens? 馃槄 馃檭

idk, what's the process here? do we need a deprecation in this case?

@kategengler
Copy link
Member

Do they know it is private if it is hanging out on Ember.Handlebars.Utils.escapeExpression?

If it is truly private, we need an intimate API deprecation (1 LTS cycle), but if it is public, we need an RFC + full deprecation.

@bertdeblock
Copy link
Member

I know ember-intl uses it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants