Removed escapeExpression from @ember/-internals (may be deprecated) #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
force-pushed
the
remove-escapeExpression
branch
from
cfe637c
to
a8b7a10
Compare
ijlee2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Ember.Handlebars.Utils.escapeExpressionmay be deprecated. The related file is the only place where we writeimport Ember from 'ember';.escapeExpressionfrom@ember/templateemberjs/ember.js#20627import Ember from 'ember'emberjs/rfcs#1003Solution?
ember-intlhas been callingescapeExpression()only whentypeof val === 'string'is equal totrue. As a result, lines 89-102 can never be executed, and we can copy a small piece of code to keep the existing behavior.