Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EMBER_EXTEND_PROTOTYPES #19661

Merged
merged 2 commits into from Jul 20, 2021
Merged

Remove EMBER_EXTEND_PROTOTYPES #19661

merged 2 commits into from Jul 20, 2021

Conversation

nlfurniss
Copy link
Contributor

Part of #19660

Deprecation Guide

Tests pass locally

@mixonic mixonic mentioned this pull request Jul 19, 2021
58 tasks
@mixonic
Copy link
Sponsor Member

mixonic commented Jul 19, 2021

I think I would like to see #19654 land first as I think it is a subset of this removal? I haven't looked closely at them.

See also the issue around htmlSafe mentioned on that PR.

@nlfurniss
Copy link
Contributor Author

I think I would like to see #19654 land first as I think it is a subset of this removal? I haven't looked closely at them.

See also the issue around htmlSafe mentioned on that PR.

As I understand it (and this may be wildly incorrect), this PR removes setting/reading the extension prototype setting on the Ember obj, while setting/reading it from EmberEnv is allowed:

'Accessing Ember.EXTEND_PROTOTYPES is deprecated, please migrate to Ember.ENV.EXTEND_PROTOTYPES'

@mixonic mixonic merged commit 24871aa into emberjs:master Jul 20, 2021
@nlfurniss nlfurniss deleted the remove-EXTEND_PROTOTYPES branch July 20, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants