Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix Embroider compatibility with ember-source@3.27.2+ #19586

Merged
merged 4 commits into from Jun 3, 2021

Commits on Jun 2, 2021

  1. Extract separate global deprecation helpers into standalone module.

    No logical changes here, just moving the code to detect and generate the
    message out into a stand alone module (makes it easier to reason about
    and possible to unit test).
    
    Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
    rwjblue and stefanpenner committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    aef0c07 View commit details
    Browse the repository at this point in the history
  2. Add some basic tests

    Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
    rwjblue and stefanpenner committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    540fafa View commit details
    Browse the repository at this point in the history
  3. Refactor @ember/-internals/bootstrap back into an IIFE

    Fixes a few things:
    
    * Ensures that Embroider has a consistent protocol for ensuring the
      global is bootstrapped
    * Allows our override code to be transpiled
    * Ensures that any bootstrapping tweaks force us out of "prebuilt" mode
      (allowing that customized bootstrap code to actually run)
    
    Co-authored-by: Stefan Penner <stefan.penner@gmail.com>
    rwjblue and stefanpenner committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    fffe619 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Refactor Overrides infrastructure, add more tests

    Also fixed a few minor errors in the message (wrong version number etc)
    
    Included a list of hardcoded known dormant addons (polyfills mostly) to make
    the suggestions more reliable.
    chancancode committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    35689f9 View commit details
    Browse the repository at this point in the history